We need tests for Storm Note

CommentFileSizeAuthor
#5 storm--918760-5.patch7.68 KBjuliangb
#3 storm--918760-3.patch5.33 KBjuliangb
#1 storm--918760-1.patch1.92 KBjuliangb

Comments

juliangb’s picture

juliangb commented
Status: Active » Needs review
StatusFileSize
new storm--918760-1.patch1.92 KB

Patch for review.

Status: Needs review » Needs work

The last submitted patch, storm--918760-1.patch, failed testing.

juliangb’s picture

juliangb commented
Status: Needs work » Needs review
StatusFileSize
new storm--918760-3.patch5.33 KB

I expect this to solve all but 1.

Status: Needs review » Needs work

The last submitted patch, storm--918760-3.patch, failed testing.

juliangb’s picture

juliangb commented
Status: Needs work » Needs review
StatusFileSize
new storm--918760-5.patch7.68 KB

The stormnote table seems to have a field for the step number of the task that the note is attached to. This never seems to be populated or used, so I have removed it.

Open to discussion on this.

juliangb’s picture

juliangb commented
Status: Needs review » Reviewed & tested by the community

This passes. I will commit in around a week if there have been no objections to removing the db field - see #5.

tchurch’s picture

tchurch commented

IMHO I'm not sure why the step number was needed on the note record. It seems like duplicating information.
I have no objection to removing it (that's my tuppence worth :) )

juliangb’s picture

juliangb commented

#5: storm--918760-5.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, storm--918760-5.patch, failed testing.

juliangb’s picture

juliangb commented
Status: Needs work » Needs review

#5: storm--918760-5.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, storm--918760-5.patch, failed testing.

juliangb’s picture

juliangb commented

Fails due to #996512: D6 contrib project tests: [MySQL] Drupal installation failed.. Needs retest once that is sorted.

juliangb’s picture

juliangb commented
Status: Needs work » Needs review

#5: storm--918760-5.patch queued for re-testing.

juliangb’s picture

juliangb commented

Committed to CVS.

juliangb’s picture

juliangb commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.