follow-up to fix problems due to #909728: fix property-rename problems

CommentFileSizeAuthor
#1 rules_fix.patch947 bytesfago

Comments

fago’s picture

fago
Primary language German
Location Vienna
commented
Component: Rules Core » Rules Engine
Status: Active » Needs review
StatusFileSize
new rules_fix.patch947 bytes

I had a short look at this issue and I think/hope I found the problem. Does the attached patch fix it for you? Have you specified the variable name with an underscore? (no dash!)

Basically it should have worked but the first (unnecessary) was wrong as it didn't pass the varname to RulesState::get().

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

Hm, bad bot. The tests are fine for me -> so I've gone ahead and committed it. Please report back whether it fixes the problem for you.

BenK’s picture

BenK commented

Thanks, fago. I'll test this and report back...

BenK’s picture

BenK commented

I can confirm that the "privatemsg-message:author" issue reported by Berdir on the other thread is now fixed! :-)

We're still having an issue with "privatemsg_message:thread-id", but I need to check with Berdir if that one is still using the old dash format. We're currently getting the following error message:

10.518 ms Unable to apply data selector privatemsg_message:thread-id: Unknown data property thread_id.

--Ben

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.