issue is most evident when dealing with custom scripts which reside outside of web root which forces developer to change value of DRUPAL_ROOT.

This patch fixes discrepancy between drupal_load and drupal_get_filename where drupal_load uses DRUPAL_ROOT and drupal_get_filename does not.

CommentFileSizeAuthor
#2 drupal_get_filename.patch758 bytesdavehimself
drupal_get_filename.patch1.05 KBlitwol

Comments

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Needs review » Reviewed & tested by the community
davehimself’s picture

davehimself commented
StatusFileSize
new drupal_get_filename.patch758 bytes

This patch was not OS agnostic. Updated to use DIRECTORY_SEPARATOR

davehimself’s picture

davehimself commented
Status: Reviewed & tested by the community » Needs review
litwol’s picture

litwol commented

DIRECTORY_SEPARATOR is used only 4 times in whole core (including 2 times in simpletest). I am not sure whether this is absolutely necessary. on a flip side it can't really hurt.

damien tournoud’s picture

damien tournoud commented
Status: Needs review » Needs work

We indeed don't use DIRECTORY_SEPARATOR here.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Needs work » Reviewed & tested by the community

Ok, then we use the first patch.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.