mollom-settings-page.jpg

CommentFileSizeAuthor
#3 mollom-settings.patch4.11 KBdries
#1 mollom-HEAD.settings-ui.1.patch3.46 KBsun
mollom-settings-page.jpg463.99 KBdries

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs review
StatusFileSize
new mollom-HEAD.settings-ui.1.patch3.46 KB

Good suggestions. Shortened the positive API keys message some more. Always found that one odd.

dries’s picture

dries commented

The tests don't seem to run so I'm running them locally.

dries’s picture

dries commented
StatusFileSize
new mollom-settings.patch4.11 KB

One test fails:

"We are now blocking spam." found Other mollom.test 830 MollomInstallationTestCase->testInstallationProcess()

I fixed the tests and I'm attaching them here.

dries’s picture

dries commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)

Committed to CVS HEAD. Let's backport to Drupal 6.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Patch (to be ported) » Fixed

Applies cleanly to D6. Ran the Installation test manually, which passed.

Thanks for reporting, reviewing, and testing! Committed to D6.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit c10e829 on master, fai6, 8.x-2.x, fbajs, actions by Dries: 
    - Patch #923264 by sun: collection of setting page clean-ups.

  • Commit c10e829 on master, fai6, 8.x-2.x, fbajs, actions by Dries: 
    - Patch #923264 by sun: collection of setting page clean-ups.