admin/structure/menu/settings

There is a typo in menu_configure() causing a warning:

Notice: Undefined variable: main_options in menu_configure() (line 702 of /modules/menu/menu.admin.inc).

It also causes the name of the menu not to be displayed. Patch attached.

CommentFileSizeAuthor
menu.admin_.inc-typo.patch1.32 KBpfrenssen

Comments

mustanggb’s picture

mustanggb commented

Instead of:

array('%main' => $menu_options[$main])

Shouldn't it be:

array('%main' => $main_options)
pfrenssen’s picture

pfrenssen
Location Sofia
commented

No, $main_options does not exist in this function.

The description wants to print out the name of the menu that is currently used for the Main Links. This is stored in $menu_options[$main].

mustanggb’s picture

mustanggb commented

It did a few days ago :P
I see in the latest CVS it has disappeared though

Jeff Burnz’s picture

Jeff Burnz commented

Fixes the problem for me.

attiks’s picture

attiks commented
Status: Needs review » Reviewed & tested by the community

Ran into the same problem, after applying patch, notice is gone ;p

tom_o_t’s picture

tom_o_t commented

menu.admin_.inc-typo.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, menu.admin_.inc-typo.patch, failed testing.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Needs work » Fixed

This has been fixed in another issue: #937850: PHP notice in menu settings page.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.