Error icon is repeated on Field Settings UI [#925886]

As per the attached screenshot, an error message on admin/structure/types/manage/%type/fields/%field/field-settings is not readable because the error icon is repeated behind it. The surrounding <div> has the .error CSS class, but not the .messages CSS class.

Three patches are attached with 3 different fixes;

Add the .messages class.
Turn the message into a drupal_set_message()-message, since these settings now have their own page/UI/form in Drupal 7, and this message is probably just left over from Drupal 6 CCK where these settings were mixed with the widget settings form.
Remove the message altogether, since (I think) there are no form elements that are both visible and disabled.

I'm not certain which is the best fix, but I believe it is number 3.

Comment	File	Size	Author
#2	925886.patch	1.54 KB	Bevan
	field-ui-error-3.patch	1.04 KB	Bevan
	field-ui-error-2.patch	938 bytes	Bevan
	field-ui-error-1.patch	1020 bytes	Bevan
	Repeated error icons.png	150.19 KB	Bevan

Comments

Comment #1

Bevan commented 30 September 2010 at 04:17

Status:

Active

» Needs review

Comment #2

Bevan commented 30 September 2010 at 04:20

Status	File	Size
new	925886.patch	1.54 KB

The third patch has an error. Replacement attached.

Comment #3

yched commented 6 October 2010 at 12:22

Patch 1 looks like the way to go. We can't display this with drupal_set_message(), because the message would be redisplayed when the form is submitted.