Right now contact forms get one of two ID's:

#contact-site-form
#contact-personal-form

What I would like is a class to cover both of them in one hit. This cropped up in #778290: Further style Bartik's contact form where we are forced to needlessly use both selectors to style both forms at the same time. If we had a class we could write less code.

The patch proposes to add the class .contact-form to both forms.

CommentFileSizeAuthor
#1 add-class-to-contact-forms.patch826 bytesJeff Burnz

Comments

Jeff Burnz’s picture

Jeff Burnz commented
Title: Add class to contact forms to make theming them easier » Add class to contact forms to make theming easier
Status: Active » Needs review
StatusFileSize
new add-class-to-contact-forms.patch826 bytes

and the patch...

markabur’s picture

markabur commented

Makes sense. Small addition that will allow for simpler css. +1

rjgoldsborough’s picture

rjgoldsborough commented

+1 as well. Works exactly as described by adding a contact-form class to both the site wide and user contact forms.

bleen’s picture

bleen commented
Status: Needs review » Reviewed & tested by the community

excellent

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 7.x-dev » 8.x-dev

Although badly needed, this sounds like D8 material to me.

Jeff Burnz’s picture

Jeff Burnz commented

Agreed, this is D8 material.

bleen’s picture

bleen commented
Version: 8.x-dev » 7.x-dev
Priority: Normal » Minor

Obviously this is not the most important issue in the queue but it is (a) uber helpful for themers (b) simple (c) ready to go

Based on the comment here #927792-3: Please explain what is still considered for D7 I dont think this needs to be postponed to D8 (as this does not require any api change) but it certainly shouldn't be high up on Dries/Webchick's radar (so I'm setting priority to minor).

bleen’s picture

bleen commented
Category: feature » task
Issue tags: +Quick fix

tagging ... also, I dont think this is a feature request and I dont think it's a bug, so task?

markabur’s picture

markabur commented
Status: Reviewed & tested by the community » Closed (duplicate)

This went in as part of #778290: Further style Bartik's contact form.