After fixing the problem in http://drupal.org/node/926516, I checked the ststus report and found this:
Warning: Invalid argument supplied for foreach() in token_find_duplicate_tokens() (line 636 of /var/www/clients/client2/web2/web/sites/all/modules/token/token.module)
Also:
Duplicate tokens The following tokens are defined by multiple modules and may cause problems when performing token replacement.
* node:node-url (defined by modules: token, notifications_content)
I get what it's saying, I just can't seem to make it go away.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | token_find_duplicate_check_2-D6.patch | 542 bytes | jcmarco |
| #3 | token_find_duplicate_check.patch | 502 bytes | jcmarco |
Comments
Comment #1
dave reidThe latter is a duplicate of #845250: Duplicate [node-url] token definition with token module.
Comment #2
wxman commentedYou're right that did fix the second part. I'm still getting the first error though.
Comment #3
jcmarco commentedThere are modules that return empty arrays when queried for tokens type 'all' (sms_user, signup, signup_status..)
and there are others buggy modules than not return even anything (location_cck)
So for the first bug, it would be needed an extra check in the token_find_duplicate_tokens().
There is room for an extra future feature maybe some warning for buggy modules using the token API wrongly.
Comment #4
dave reidWe should use the same check as module_implements() -
if (!isset($module_tokens) || !is_array($module_tokens))Comment #5
wxman commentedThat patch worked the trick. No more errors are showing up anywhere now. Thanks.
Comment #6
jcmarco commentedAdded the extra checks and not stop the module analysis, just jump over the wrong modules.
Comment #7
dave reidThanks, committed to CVS: http://drupal.org/cvs?commit=430228