Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Hi I already mentioned this problem in this issue: #896728-9: Tweaks to jQuery UI Seven theme
The interaction states classes should be implemented like the the ones in /misc/ui/jquery.ui.theme.css, so that every widget has appearances their states. I also noticed that the corner classes where missing(for round corners), since people might need it.
I attached some screenshots to clarify the problem, and a patch the also fixes the first comment, since there is no file /misc/ui/ui.theme.css.
Comment | File | Size | Author |
---|---|---|---|
#14 | drupal-928572-4.patch | 2.45 KB | sepgil |
#15 | drupal-928572-4.patch | 2.45 KB | sepgil |
#10 | ui-state_after.jpg | 99.71 KB | idflood |
#6 | drupal-928572-3.patch | 3.09 KB | sepgil |
#5 | rules-905158-3.patch | 10.28 KB | sepgil |
Comments
Comment #2
Jeff Burnz CreditAttribution: Jeff Burnz commentedhex should be lower case, I can see this is inconsistent in this file, but lets try to keep to the coding standards for new additions.
again we've got in inconsistency in standards here, in some places we're simply copy/pasting from jquery.ui.theme.css and in others we're reformatting to match our coding standards.
Powered by Dreditor.
Comment #3
sepgil CreditAttribution: sepgil commentedMaybe we should open open issue for the code style violation...
Meanwhile I corrected the code style issues of my patch...
Comment #5
sepgil CreditAttribution: sepgil commentedThis patch should apply...
Comment #6
sepgil CreditAttribution: sepgil commentedAh! I'm getting confused with all my patches, sorry!
This is the right patch...
Comment #7
fagopatch looks good to me, but I wonder how it overlaps with #896728: Tweaks to jQuery UI Seven theme
Comment #8
fago#6: drupal-928572-3.patch queued for re-testing.
Comment #9
fagoPatch works fine for me, it's required for the Rules ui to look properly..
Any reviews?
Comment #10
idflood CreditAttribution: idflood commentedThe last patch works fine for me ( and looks ok by reading it ). I only applied #6 and it looks like the attached image. ( firefox 3.6.10, osx )
I quickly changed the values of the .rules-autocomplete-button with firebug. Here are the values I had to use to get something similar to "ui-state_after.jpg" in #0:
height: 19px;
top: 6px;
Comment #11
sepgil CreditAttribution: sepgil commented#6: drupal-928572-3.patch queued for re-testing.
Comment #12
sepgil CreditAttribution: sepgil commentedThe damn button always is displayed different, depending on the os(even if the browser is the same), but thats a rules issue.
It would be cool, if we could bring this patch into core, since it is needed for rules and for my module autocomplete deluxe.
Comment #13
fagoPatch looks good to me, is reported to work + fixes some code style issues in that file. However I do not think we need to comment "/*cornerRadius*/" in each line, as the lines already say that itself let's just remove those comments.
Comment #14
sepgil CreditAttribution: sepgil commentedOk, I deleted all those comments.
Comment #15
sepgil CreditAttribution: sepgil commentedOk, I deleted all those comments.
Comment #16
sepgil CreditAttribution: sepgil commentedsorry, for the triple post, clicked the wrong button(s)...
Comment #17
drupalycious CreditAttribution: drupalycious commentedHello,
the patch doesn't work against Drupal 7.15. I got the following message:
Fago, is it still necessary to apply it with the latest dev version of rules?
Thanks