Hi I already mentioned this problem in this issue: #896728-9: Tweaks to jQuery UI Seven theme
The interaction states classes should be implemented like the the ones in /misc/ui/jquery.ui.theme.css, so that every widget has appearances their states. I also noticed that the corner classes where missing(for round corners), since people might need it.

I attached some screenshots to clarify the problem, and a patch the also fixes the first comment, since there is no file /misc/ui/ui.theme.css.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, drupal-ui-state-seven.patch, failed testing.

Jeff Burnz’s picture

+++ b/themes/seven/jquery.ui.theme.css
@@ -21,10 +21,19 @@
+  border: 1px solid #CCCCCC;

hex should be lower case, I can see this is inconsistent in this file, but lets try to keep to the coding standards for new additions.

+++ b/themes/seven/jquery.ui.theme.css
@@ -431,3 +440,16 @@
+.ui-corner-tl { -moz-border-radius-topleft: 4px/*{cornerRadius}*/; -webkit-border-top-left-radius: 4px/*{cornerRadius}*/; border-top-left-radius: 4px/*{cornerRadius}*/; }

again we've got in inconsistency in standards here, in some places we're simply copy/pasting from jquery.ui.theme.css and in others we're reformatting to match our coding standards.

Powered by Dreditor.

sepgil’s picture

Status: Needs work » Needs review
FileSize
3.1 KB

Maybe we should open open issue for the code style violation...

Meanwhile I corrected the code style issues of my patch...

Status: Needs review » Needs work

The last submitted patch, drupal-928572-2.patch, failed testing.

sepgil’s picture

Status: Needs work » Needs review
FileSize
10.28 KB

This patch should apply...

sepgil’s picture

FileSize
3.09 KB

Ah! I'm getting confused with all my patches, sorry!
This is the right patch...

fago’s picture

patch looks good to me, but I wonder how it overlaps with #896728: Tweaks to jQuery UI Seven theme

fago’s picture

#6: drupal-928572-3.patch queued for re-testing.

fago’s picture

Patch works fine for me, it's required for the Rules ui to look properly..

Any reviews?

idflood’s picture

Status: Needs review » Needs work
FileSize
99.71 KB

The last patch works fine for me ( and looks ok by reading it ). I only applied #6 and it looks like the attached image. ( firefox 3.6.10, osx )

I quickly changed the values of the .rules-autocomplete-button with firebug. Here are the values I had to use to get something similar to "ui-state_after.jpg" in #0:
height: 19px;
top: 6px;

sepgil’s picture

Status: Needs work » Needs review

#6: drupal-928572-3.patch queued for re-testing.

sepgil’s picture

The damn button always is displayed different, depending on the os(even if the browser is the same), but thats a rules issue.

It would be cool, if we could bring this patch into core, since it is needed for rules and for my module autocomplete deluxe.

fago’s picture

Status: Needs review » Needs work

Patch looks good to me, is reported to work + fixes some code style issues in that file. However I do not think we need to comment "/*cornerRadius*/" in each line, as the lines already say that itself let's just remove those comments.

sepgil’s picture

FileSize
2.45 KB

Ok, I deleted all those comments.

sepgil’s picture

FileSize
2.45 KB

Ok, I deleted all those comments.

sepgil’s picture

Status: Needs work » Needs review

sorry, for the triple post, clicked the wrong button(s)...

drupalycious’s picture

Hello,

the patch doesn't work against Drupal 7.15. I got the following message:

patching file themes/seven/jquery.ui.theme.css
patch unexpectedly ends in middle of line
patch: **** malformed patch at line 100:

Fago, is it still necessary to apply it with the latest dev version of rules?

Thanks