Followup to #699848: admin/by-task is confusing since it lacks links to config pages and looks similar to admin/config and friends:

If you go to /admin you can see that some of the menu item descriptions printed there are complete sentences (with a period at the end) and some aren't. The periods probably aren't there in the original items because people wanted them to look nice when appearing as a hover tooltip in the Toolbar...

But now that they are front and center menu item descriptions we probably really should just put a period at the end of each of them :)

CommentFileSizeAuthor
#1 admin-descriptions-periods-928790-1.patch3.96 KBDavid_Rothstein

Comments

David_Rothstein’s picture

David_Rothstein commented
Status: Active » Needs review
StatusFileSize
new admin-descriptions-periods-928790-1.patch3.96 KB

Very simple patch, and the toolbar tooltips look perfectly fine with a period at the end also.

I'm tempted to just RTBC this patch myself :)

Bojhan’s picture

Bojhan commented
Status: Needs review » Reviewed & tested by the community

There we go, will see if it gets comitted or not given that we are in text freez and this is polish.

David_Rothstein’s picture

David_Rothstein commented

Thanks. Should be OK - it is a plain old bugfix, and @webchick has indicated she'd commit minor UI changes as long as they solve a bug.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

This is kinda stretching the limits of bug fix vs. polish, but unlike other patches that do this, this has an extremely low chance of actually breaking anything afterwards.

Committed to HEAD. Thanks!

David_Rothstein’s picture

David_Rothstein commented

Thanks. Well, I figured grammatical errors count as bugs, but yeah, maybe I should have marked it "minor"...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.