module_list kills system_list caching

+++ includes/module.inc	2010-10-02 01:38:09 +0000
@@ -65,9 +65,11 @@ function module_list($refresh = FALSE, $
+      if ($refresh) {
+        system_list_reset();

This looks correct.

Too bad we're mixing 'refresh' and 'reset'.

Let's see what the testbot has to say.

In addition to adding the obviously missing "if ($refresh)..", IIRC chx and I also discussed reverting system_list_reset() back to drupal_static_reset(), that change was suggested here: http://drupal.org/node/651086#comment-3500108

Reverting would fix a related issue: http://api.drupal.org/api/function/module_load_all/7 uses $refresh = TRUE and is called on every bootstrap, which is constantly dumping the cache bins via system_list_reset(). I think it's more a problem of module_load_all() using $refresh = TRUE, but I'll leave that to another issue, since chx pleaded me not to touch that :) Attached patch reverts back to drupal_static_reset('system_list').

Committed to CVS HEAD. Thanks.

This is the sort of silly bug that happens when you have so many caches that you can't track what needs refreshing and resetting for a given operation. I'm probably preaching to the choir here.