Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Oct 2010 at 02:00 UTC
Updated:
3 Jan 2014 at 02:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
beanjammin commentedSuggested changes.
Comment #2
axyjo commented+1, but I'll wait for someone else to RTBC.
Comment #3
EvanDonovan commented"ie" should be "i.e." - I'll roll a new patch in a minute.
Comment #4
EvanDonovan commentedCorrected spelling of "i.e." - also made a few other minor proofreading edits.
I'm not totally happy about this being the last bullet in the top list, since it takes away from the finality of "You have read through this entire document," but I don't see a better place for the warning, and it is absolutely essential that it be added to the document in a prominent place.
Hopefully someone can RTBC soon.
Comment #5
EvanDonovan commentedHere's an alternative version with the new sentence not part of the bulleted list. I actually prefer this one, but I'll let the community decide.
Either way, I think the wording is good (I didn't change that from Beanjammin's original patch).
Comment #7
fgmI understand why you added the final dot, but it is likely to be confusing and limit copy/paste ability for users reading this in a downloaded text file. I think it would be better to leave it off.
Comment #8
EvanDonovan commented@fgm: This patch fixes that. Also fixes the white space issue pointed out by marvil07.
I suffixed with D6 to prevent "wasting" a test bot. Let me know if I should've sent it to test bot. (I did test locally that it applied, and obviously it has no effect on code.)
I also attached the full updated file if that will help anyone review.
Comment #9
David_Rothstein commentedLooks like a no-brainer to me.
I think the testbot probably could have survived your one-patch onslaught :) But yes, there is obviously no way this could break tests. (Unless there's a mistake in the instructions and the testbot is smart enough to read English and therefore is led astray by what it reads...)
Comment #10
webchickCommitted to HEAD. Thanks! :)