I noticed this while working on action_example.

CommentFileSizeAuthor
#5 examples.trigger_alter_929504_05.patch2.95 KBrfay
#3 trigger_example_info_alter_3.patch3.16 KBilo
trigger_example_info_alter.patch3.2 KBilo

Comments

Status: Needs review » Needs work

The last submitted patch, trigger_example_info_alter.patch, failed testing.

ilo’s picture

ilo commented

I'm verifying why, and changed strtoupper() with drupal_strtoupper()

ilo’s picture

ilo commented
Status: Needs work » Needs review
StatusFileSize
new trigger_example_info_alter_3.patch3.16 KB

oh, it was uppercased because of the styling..

ilo’s picture

ilo commented

Please, verify coder issues before commiting. I forgot to do.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
StatusFileSize
new examples.trigger_alter_929504_05.patch2.95 KB

Looks good to me. Tiny line wrapping issues here. Looks good in coder too.

Thanks!

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Fixed

Committed to HEAD: http://drupal.org/cvs?commit=436236

Thanks!

ilo’s picture

ilo commented

wow.. patch failed applying? what have you committed, rfay? lol!

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

I just jumped the gun and committed before the test arrived at qa :-)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.