The messages look weird when they appear above the Featured region - I dont think this looks very good but can't really think of a better solution other than adding the same background to messages (with slight layout adjustments to support this).
I think this is a visual bug, the active tab is meant to be the same color as featured (will be fixed when the patch we have for that lands) so you get this big white space above the featured region when a message appears.
I'm not overly fussed about this but would like to hear peeps thoughts.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | featured-messages_2.patch | 1.15 KB | Jeff Burnz |
| #4 | bartik-featured-message.png | 21.81 KB | Jeff Burnz |
| featured-messages.patch | 1.15 KB | Jeff Burnz |
Comments
Comment #1
jensimmons commentedputting on my list of things to look at
Comment #2
tim.plunkettsub
Comment #3
Jeff Burnz commentedprobably gonna fail...
Comment #4
Jeff Burnz commentedRe-roll with screenshot (after patch).
Comment #5
tim.plunkettMakes sense to me, and looks good too.
Comment #6
jensimmons commentedlooks good to me too.
Comment #7
webchickIf you, like me, were wondering what this looked like before and why this is considered a bug fix, this is what it looks like without this patch:
After, it makes the entire area grey and consistent like in #4.
Looks good here.
Committed to HEAD. Thanks.