CommentFileSizeAuthor
#3 DrupalErrorCollectionUnitTest.patch1.13 KBAnonymous (not verified)
#1 fail.jpg460.75 KBAnonymous (not verified)

Comments

Anonymous’s picture

StatusFileSize
new460.75 KB

this is weird. i can't reproduce the fail at 'head-status', but i can reproduce fails in the simpletest error collector. screenshot attached.

dww’s picture

I'm consistently getting the same results as #1, even going back to HEAD from 2010-09-22. :( I've got a freshly built PHP 5.3.3 -- wondering if that's somehow breaking the plumbing of the error collector test...

Anonymous’s picture

Status: Active » Needs review
StatusFileSize
new1.13 KB

ok, no idea why we didn't see this before, because it looks like it should have been broken forever.

when overriding DrupalWebTestCase::error(), we'd neglected to ignore 'User notice' errors, as these are used for debugging, specifically in DrupalWebTestCase::verbose().

attached patch fixes that.

damien tournoud’s picture

Status: Needs review » Closed (duplicate)

That last bug is #614082: “SimpleTest error collector” tests fail when verbose logging is enabled.

Not sure which tests failed in the first place in 'head status'.

dww’s picture

Status: Closed (duplicate) » Closed (cannot reproduce)
Issue tags: -beta blocker

The local test failures are indeed duplicate with #614082. However, that doesn't explain why the test bot thought HEAD was broken. But, apparently, it resolved itself, so I'm marking this cannot reproduce for now. Let's hope it stays this way.