'file_temporary_path' variable and file_directory_temp() function should match

Subscribe. :-) Awaiting D8!

subscribe

So do we want to rename the variable to match the function, or do we want to rename the function to match the variable?

#5: rename-file_directory_temp-to-file_temporary_path-931794-5.patch queued for re-testing.

#5: rename-file_temporary_path-to-file_directory_temp-931794-5.patch queued for re-testing.

#5: rename-file_directory_temp-to-file_temporary_path-931794-5.patch queued for re-testing.

#5: rename-file_temporary_path-to-file_directory_temp-931794-5.patch queued for re-testing.

Probably needs to wait until 9.

https://api.drupal.org/api/drupal/core%21includes%21file.inc/function/fi...

We could move file_direcotry_temp() to a service method in 8.x, and potentially rename the config key with a bc layer too.

Unpostponing, don't fully understand the problem here, but we do need a new place and name for this function anyway and it can't be FileSystem due to its dependency on the configuration system.

See also #3034072-3: Move file uri/scheme functions from file.inc and FileSystem to StreamWrapperManager (comment #3)

Created #3039026: Deprecate file_directory_temp() and move to FileSystem service

Since file_directory_temp() has been deprecated it seems likely that this can be closed as outdated.

First check where file_directory_temp is used.

$ grep -ri file_directory_temp core
core/modules/file/src/Plugin/migrate/source/d6/File.php:    $this->tempFilePath = $this->variableGet('file_directory_temp', '/tmp') . '/';
core/modules/migrate_drupal/tests/fixtures/drupal6.php:  'name' => 'file_directory_temp',
core/modules/user/src/Plugin/migrate/source/d6/UserPictureFile.php:    $this->tempFilePath = $this->variableGet('file_directory_temp', '/tmp') . '/';
core/lib/Drupal/Core/Database/Driver/sqlite/Install/Tasks.php:        // We cannot use file_directory_temp() here because we haven't yet

Three of the four occurrences are in the migration system, referring to a Drupal 6 source database, so those are correct and remain unchanged. The other is in a comment in sqlite/Install/Tasks.php. The full comment is

        // We cannot use file_directory_temp() here because we haven't yet
        // successfully connected to the database.

and since it is referring to a now removed function it should be removed. Removing that is not part of this issue, that can be done in a followup to #3039026: Deprecate file_directory_temp() and move to FileSystem service. But it does mean that there is the work here is outdated.

Created a followup to remove the comment referring to file_directory_temp(). #3157370: Modify comment referring to file_directory_temp().

Adding BugSmash Initiative tag and closing as outdated, because of #3039026: Deprecate file_directory_temp() and move to FileSystem service.

Thanks to dww for the report and to pillarsdotnet for creating a patch.