menu_link_get_preferred() can cause illegal SQL [#931796]

On ex2, we have set menu_default_active_menus', array_keys(menu_list_system_menus())) to an array, because no menu module created menus get displayed on the site, and having an empty array saves some unnecessary processing.

However menu_link_preferred() puts the results of that variable into an IN() condition, causing illegal SQL if it's empty.

The patch is easy but I need to check if the resultant query can use indexes.

Comment	File	Size	Author
#4	menu_names.patch	1.18 KB	catch
#4
	menu_names.patch	666 bytes	catch

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

catch

he/him

English

CreditAttribution: catch commented 5 October 2010 at 06:37

hmm, the use case for setting this to an empty array appears to have disappeared, because this is no longer called via the same code path, however an empty array is still a valid value.

Comment #2

catch

he/him

English

CreditAttribution: catch commented 5 October 2010 at 06:39

Priority:

Normal

» Minor

Comment #3

Damien Tournoud CreditAttribution: Damien Tournoud commented 5 October 2010 at 08:29

Priority:	Minor	» Normal
Status:	Needs review	» Needs work

An empty $menu_names doesn't mean "all menus should be considered" by "no menus should be considered". That means that we have to simply return NULL here.