On a clean Drupal 7 beta1 install, I created three books with some child pages. When I enable the Book Navigation block, the following error message appears multiple times:
Notice: Undefined index: access in menu_tree_output() (line 963 of /[...]/includes/menu.inc).
- This doesn't seem to be theme related.
- Disabling the Book Navigation block makes the error message disappear.
PHP: 5.2.14
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | book_navigation_test_failing.patch | 5.67 KB | drunken monkey |
| #15 | book_navigation.patch | 6.51 KB | drunken monkey |
| #7 | book_navigation_block.patch | 869 bytes | ygerasimov |
| #5 | Undefined Index | 46.89 KB | olafveerman |
Comments
Comment #1
olafveerman commentedComment #2
damien tournoud commentedI cannot reproduce.
Could you give us specific steps to reproduce this issue?
Comment #3
damien tournoud commentedActually, I can reproduce.
This happens on the frontpage (or any page that is not related to a book) as soon as there is at least a book defined in the installation.
Comment #4
damien tournoud commentedComment #5
olafveerman commentedIn my case it also occurs on book related pages. In Alpha 6 this problem doesn't occur.
Comment #6
VladGh commentedDoing a ddebug_backtrace I see that the Boolean "access" element is inserted correctly by the menu.inc function at line 937 but somehow it gets stripped by the book.module somewhere between line 253 and 274. That is the 'all pages' section. I guess is the $pseudo_tree at line $268. If the block is configured to be shown only on the book pages it works flawlessly. It also works if the current page is from a book.
Comment #7
ygerasimov commentedI think this happens because we do not check whether current user can access the node of the book. Please review the patch that does this check.
Comment #8
VladGh commentedIt works in my case, thank you. Now the ['link'] array has the 32nd element "access (Boolean) TRUE".
Comment #9
ygerasimov commentedCan someone test as well so we can move this isuue to RTBC?
Comment #10
VladGh commented#7: book_navigation_block.patch queued for re-testing.
Comment #11
VladGh commentedI'm sorry I didn't mean to re-test it.
Comment #12
olafveerman commentedGreat, the patch also works for me!
Comment #14
webchickCan we add a test here that demonstrates the bug so we ensure we don't get it again in the future?
Comment #15
drunken monkeyThere already was a test, but before it only tested, whether you could edit the block title. Interesting …
Also, the file had a lot of trailing whitespace in it. (This patch removes it – I hope this is the correct way in such a case.)
However, this works for me. I'd also say this is major, since it makes book navigation unusable for many use cases. But leaving it at normal for the time being.
Comment #16
ygerasimov commentedThomas, thank you for the reorganizing tests and removing trailing spaces. The test included in http://drupal.org/files/issues/book_navigation_2.patch catches the bug.
Comment #17
webchickAwesome. Committed to HEAD, thanks! :D