Closed (fixed)
Project:
Examples for Developers
Component:
Menu Example
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Oct 2010 at 17:07 UTC
Updated:
28 Oct 2010 at 19:10 UTC
Jump to comment: Most recent file
Comments
Comment #2
ilo commentedOk, current debug info..
My bet is that both fails come from this commit:
#925778: User edit title is broken (so is beta1-beta2 upgrade path) by mradcliffe, chx, sun, manarth: Fixed user edit title incorrectly shows currently logged in user.
Take a look at this diff: http://drupalcode.org/viewvc/drupal/drupal/modules/user/user.module?r1=1...
The menu_example hook_menu_alter is changing the user/logout menu entry. This is a very good example but a very bad choice, because of the following issues:
- user.module:1794 user_menu_link_alter() signature sais: Force the Logout link to appear on the top-level of 'user-menu' menu by default (i.e., unless it has been customized), if menu_example:380 unsets ($items['user/logout']) it will no longer appear in the page.
- DrupalWebTestCase drupalLogin uses user/logout to logout a user in a testcase, and checks for this menu entry to verify the user has already logged in.
- The cause of the other test failing, user.menu:1665, because $items['user/%user_uid_only_optional'] no longer exists, and is the other change implemented in menu_example_menu_alter.
working on a patch.
Comment #3
ilo commentedLets see I testbot is my friend..
Comment #4
ilo commentedUpdated with Davereid's suggestions, overridding simpletest login and logout function, as they are failing due to module changes in menu entries.
Comment #5
rfayCommitted with tiny comment changes: http://drupal.org/cvs?commit=436170
Do we need to do this in D6 as well?
THANKS!