Closed (fixed)
Project:
Drupal for Facebook
Version:
6.x-3.x-dev
Component:
Miscellaneous
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Oct 2010 at 15:40 UTC
Updated:
18 Jan 2011 at 12:50 UTC
fb_uninstall() in fb.install ...
function fb_uninstall() {
db_query("DELETE FROM {variable} WHERE name LIKE 'fb_%'");
}The fb_social module stores all settings as "fb_xxxx" as well. Would be better if DFF explicity deleted each item in variable table instead of relying on wildcard.
Comments
Comment #1
dave reidI've always been strongly against mass-variable delete statements like this. Best practice is to follow core and call variable_del() on each variable.
Comment #2
Dave Cohen commentedJust removed that code. Now deletes each variable explicitly.