fb_uninstall() in fb.install ...

function fb_uninstall() {
  db_query("DELETE FROM {variable} WHERE name LIKE 'fb_%'");
}

The fb_social module stores all settings as "fb_xxxx" as well. Would be better if DFF explicity deleted each item in variable table instead of relying on wildcard.

Comments

dave reid’s picture

I've always been strongly against mass-variable delete statements like this. Best practice is to follow core and call variable_del() on each variable.

Dave Cohen’s picture

Version: 6.x-3.0-beta2 » 6.x-3.x-dev
Status: Active » Fixed

Just removed that code. Now deletes each variable explicitly.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.