jQuery 1.4.3 is out, with some really nice performance improvements. We should update the library to the newer version.

http://blog.jquery.com/2010/10/16/jquery-143-released/

Files: 
CommentFileSizeAuthor
#67 944308-jquery-1.4.4.patch150.8 KBjoshuajabbour
PASSED: [[SimpleTest]]: [MySQL] 27,022 pass(es).
[ View ]
#58 944308_jquery-1.4.4rc3.patch150.81 KBamateescu
PASSED: [[SimpleTest]]: [MySQL] 27,020 pass(es).
[ View ]
#34 944308_jquery-1.4.4rc2.patch137.19 KBamateescu
PASSED: [[SimpleTest]]: [MySQL] 26,780 pass(es).
[ View ]
#12 944308.patch148.09 KBbojanz
PASSED: [[SimpleTest]]: [MySQL] 26,376 pass(es).
[ View ]
#10 944308.patch148.09 KBbojanz
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 944308_0.patch.
[ View ]
#9 944308.patch148.12 KBbojanz
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 944308.patch.
[ View ]

Comments

subscribe.

Priority:Major» Critical

There is no reason in the world to ship Drupal 7 with an outdated version of jQuery.

subscribe.

Testing is as simple as overwriting misc/jquery.js with the new version.

Not sure whether it is still the most up-to-date test plan, but we have a starting point in http://groups.drupal.org/node/5974 (see the last JavaScript chapter)

Trying the large list of AJAX and JavaScript examples in the Examples module might be a good idea, too.

I don't want to start a change-the-priority battle here, so I'm not changing the priority. However this is not critical, because nothing is broken here. Quoting webchick in the issue about jQuery UI 1.8.5:

This isn't a major version change in jQuery UI, so there's no reason we couldn't roll this out in 7.1 or 7.2. No reason for it to block release. Hopefully it's ready well before that becomes an issue though. ;P

In other words: if you feel this is important, don't slow down the release, but speed up the patch.

~

subscribing

Status:Active» Needs review
StatusFileSize
new148.12 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 944308.patch.
[ View ]

Here's a patch.
Clicked through the ajax examples, they are still working.
Your turn.

EDIT: I see an unrelated line in the patch, my editor likes to fix trailing whitespace by itself. Doesn't hurt for now.

StatusFileSize
new148.09 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 944308_0.patch.
[ View ]

Now with a newline at the end of jquery.js

Status:Needs review» Needs work

The last submitted patch, 944308.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new148.09 KB
PASSED: [[SimpleTest]]: [MySQL] 26,376 pass(es).
[ View ]

Posting patches at 9AM is never a good idea...

Priority:Critical» Major

not critical as nothing is severely broken. We can deliver new versions of jquery in point releases, too.

We can deliver new versions of jquery in point releases, too

Really?!? We've never been able to before. I think that is the reason for everyones urgency here.

@bleen18: Yes we have, Drupal 6.3 introduced version 1.2.6 (was 1.2.3).

New point releases of jQuery is fine, yes. They're just standard bug fixes.

Let's have less meta-discussion and more reviewing, please. ;)

I'm not really sure how to review this other than to say I have been using the patch in #12 for the past couple of hours and I forgot about it until just now. I guess that means that I havent had any WTF moments, so thats promising :). I've definitely spent a good deal of time with v-tabs and with adding unlimited value fields...

Any advice on how else to review?

Tested in FF 3.6, Safari 5, and Chrome 6. Everything looks good. Can someone give IE a once over?

Can you expand upon what "tested" means? There are orders of magnitude more JS in Drupal 7 than there was in Drupal 6.

Tested is:
- overlay
- dashbaord
- book structure
- autocomplete
- vertical tabs
- teaser splitter
- menus drag n' drop
- blocks drag n' drop
- taxonomy drag n' drop
- openid login block/page
- contextual links
- toolbar
- color module / farbtastic

I think that was it... or was it?

This is a point release of JQuery and really shouldn't affect anything.
I doubt we'll see major breakages.
Since it's been confirmed that it's working, let's get it in, if there's a regression the testers will find it soon enough.

(In any case, I hate how blind we are on this. The days before simpletest were dark indeed)

@bojanz - even in jQuery point releases there are api changes. For example, the api to jQuery.data() changed. So, testing is important here.

That being said, everything seems to work. jQuery already makes sure for cross browser compatibility. I will be very surprised if there are failures in IE that are not in other browsers.

Status:Needs review» Reviewed & tested by the community

Now is the perfect time to do this. Sufficient time to find any obscure bugs until the next beta/RC.

Status:Reviewed & tested by the community» Fixed

Ok, agreed with sun. This means the next release of D7 will be another beta, however, to allow for sufficient testing of this and jQuery UI.

Committed to HEAD.

Incidentally, #jquery tells me that 1.4.4 is due out in about 9 days and includes fixes for bugs introduced in 1.4.3. So we might be seeing the re-opening of this issue sooner than later. :P

Yeah, whereas 1.4.3 was both bugfixes and new features, 1.4.4 is only bugfixes. So hopefully it'll be very compatible...

Title:Update to jQuery 1.4.3Widely test jQuery 1.4.3, and update to jQuery 1.4.4 if it's released soon enough
Priority:Major» Critical
Status:Fixed» Active

I found this issue and comment #24 only because it was referred to from another issue. If RC is delayed due to us needing a beta3 in order to get wide testing of jQuery 1.4.3, then that makes this an active, critical issue, right?

jQuery 1.4.4 hit rc2 today. That doesn't necessarily mean it'll be released soon, just fyi...

Too many days I hit my head on the keyboard this past year with jQuery version issues. They continue to affect me today in 6.19. Can we vow to keep jQuery support *reasonably* current and not getting behind 18 months like we did?

Say, some guideline like shipping a new jQuery version every 6 minor releases and/or 6 months, whichever comes first? Also, I would suggest making in the Status report an alert to update and show what the current jQuery version is. Drupal 7 Modules, themes, etc that rely upon jQuery should be tagged for dependencies to remind users and developers.

kkobashi, we can't ship Drupal 7 minor releases with major API changes, and that includes javascript. So new jQuery versions will likely only get included if they don't break backwards compatibility. jQuery update and etc. should be much easier in D7 contrib though than they were in D6.

It looks like a part of the difficulty here is in fact caused on the jQuery side. <daydreaming> New versions would be much easier to implement if jQuery would separate bugfix releases from api-changing releases. In that case, we could be sure that D7 is compatible with the 1.4.x branch, and we would only have to rewrite our own code (while maintaining backwards compatibility) when jQuery 1.5.0 is released. </daydreaming>

@marcvangend Well, the alternative is waiting two years for new core features like in Drupal-land. ;)

Anyway, here's the announcement for 1.4.4: http://blog.jquery.com/2010/11/03/jquery-1-4-4-release-candidate-2-released Maybe we can include the rc2 to do some testing for now?

Title:Widely test jQuery 1.4.3, and update to jQuery 1.4.4 if it's released soon enoughUpdate to jQuery 1.4.4
Issue tags:+beta blocker

If the jQuery maintainers believe there are enough regressions in 1.4.3 to warrant getting 1.4.4 out quickly after it, seems like it would be foolish to release Drupal on 1.4.3.

For the same reason, seems like it would be foolish to roll out a D7 beta-3 on 1.4.3, when 1.4.4rc2 is already out. My opinion only, but I think we should either hold up beta-3 until 1.4.4 is out, or else update to 1.4.4rc2 for beta-3, and 1.4.4 for rc1.

From the release announcement in #32:

This is the second release candidate of jQuery 1.4.4 ... and needs to be tested in live applications.

Seems like us upgrading to 1.4.4rc2 and releasing beta-3 with that within the next couple days could help our friends at jQuery with their efforts in discovering remaining bugs prior to releasing 1.4.4.

Status:Active» Needs review
StatusFileSize
new137.19 KB
PASSED: [[SimpleTest]]: [MySQL] 26,780 pass(es).
[ View ]

Here is a patch for jQuery 1.4.4rc2 so people can start testing it :)

#34: 944308_jquery-1.4.4rc2.patch queued for re-testing.

Releasing a beta with the jQuery release candidate sounds like a good plan to me. tbh I think we could just commit this as is, and then have normal usage with the dev tarball and/or a new beta take care of the additional testing. If we hold up a beta on getting this tested before it's committed, then we run the risk of being an RC or more behind again.

I'm traveling on-site with a client this week, so the very earliest I'd be able to roll another release would be around when jQuery 1.4.4 comes out (Nov. 9, according to #jquery), so we might want to just wait for it. I'll see if I can get some availability on Sunday, but don't count on it. :\

While I think it's a good idea to test it regardless, having multiple beta/RC things going at once makes it difficult to determine if the fault is with JQuery or Drupal. The same would go for beta/RC modules, but this is the only REAL way to be certain there's a stable product upon release day. So with that said, I'm agreeable to the thought of committing it for widespread testing....you're bound to find the faults if it's all simply there for the masses.

Tried the patch in #34 and found no problems at all with core. Didn't try any contrib module though.

subscribing

Once again, folks. We need details on what you tested, and in which browsers. There is lots of jQuery use in core in Drupal 7. See #20 for a guideline.

http://drupal7releasedate.com/ says that Drupal 7 will be released the day before jQuery 1.4.4 comes out. :) Won't be happening.

That site actually predicts the first release candidate, which it'd be fine to release with a 1.4.4rc.

I tested the following:

- Expandable fieldsets
- Permissions page (checkboxes)
- Sticky headers
- Unlimited fields (eg. Add choice button on Polls)
- Input filter dropdown

Together with #20 I think that's all in core?

BarisW: I may be misreading your post in #44, so just to be certain the testing done in #20 was done with JQ1.4.3 ... those tasks need to be repeated for JQ1.4.4. Is that what you tested?

Blocks drag and drop - All ok on Chrome, Firefox, Safari, IE
Menu drag and drop - All ok on Chrome, Firefox, Safari, IE
Overlay - All ok on Chrome, Firefox, Safari, IE
Vertical tabs - All ok on Chrome, Firefox, Safari, IE
Modify book structure - All ok on Chrome, Firefox, Safari, IE
Color scheme -All ok on Chrome, Firefox, Safari, IE

Using my D7 beta 2 with JQuery 1.4.2, selecting 'Edit' or 'Configure Block' from that little gear that appears when the mouse hovers over a block or content on the front page opens the edit options in the Overlay. In the dev release using JQuery 1.4.4, the edit options for content open in a different page entirely, outside of the overlay, while 'Configure Block' still opens in the overlay. Doesn't appear to be directly related to a new JQuery, but I figure I'll mention it anyway, since I encountered it during testing.

Otherwise, everything test out fine.

Browser's tested: IE7, Chrome 7, Safari 5, Firefox 3.6, all on Windows

@jgottwig, greet tests.

But you have to compare Drupal 7-dev with Drupal 7-dev+JQuery 1.4.4.
Testing "D7 beta 2 with JQuery 1.4.2" is outdated version, since the number of UI/code changes in the dev version.

ah, something I can handle. I'll be able to test this tonight, if it isn't squashed by then.

ok, getting prepared for tonight's tests I see above a full test of the javascript (from a user perspective) is:

Tested is:
- overlay
- dashbaord
- book structure
- autocomplete
- vertical tabs
- teaser splitter
- menus drag n' drop
- blocks drag n' drop
- taxonomy drag n' drop
- openid login block/page
- contextual links
- toolbar
- color module / farbtastic

I'm pretty sure I can test all of this except perhaps openid and farbtastic. Is there some documentation that explains how to do a proper test for those two?

For open ID, it's pretty simple. If you enable it, a link will appear on the user login block that you can click to swap out the regular login form for the OpenID one.

And farbtastic is just a fancy name for Colour module. :)

Thanks a lot for helping to test! It looks like there are still two open bugs until 1.4.4 "proper" gets released: http://bugs.jquery.com/milestone/1.4.4

Starting my test now...
(I'll likely be interrupted somewhere within this process, I'll be editing this post until it is complete)

Before (Testing with fresh dev as of 7:04 PM Central time)

  • Overlay Tested:
    • Chrome 9.0.574.0 (Canary Build): OK
    • Chrome 7.0.517.44: OK
    • Firefox 3.6.12: OK
    • Internet Explorer 8.0.6001.18975: OK
    • Internet Explorer 7: OK (well 8 forced into IE7's renderer and IE7's standards via Developer Tools, which is a pretty accurate in my experience)
    • Safari 5.02 (7533.18.5): OK
  • Dashboard Tested:
    • Chrome 9.0.574.0 (Canary Build): Functionally it work ok, but I was able to produce some unexpected behavior. When I would put a new block (ex: recent comment) in a dashboard region that later had content put into the block dynamically, and then put the block back into the disabled group (in the header) the block would be obese. It really looked out of place because the search bar block never plumps up. I also was able to get the title of one of the blocks to erase (accidentally). The title came back after I edited the block and changed the block title to ""
    • Chrome 7.0.517.44: same as Chrome 9, was able to get the title of the search block to disappear again. Seems to only effect the search block.
    • Firefox 3.6.12: The enlargeable block issue occurs in firefox as well. Could get the search block's title to disappear
    • Internet Explorer 8.0.6001.18975: the fatter block issues occur here too. Just noticed that when I added the Create Content block the title changed to "Add content" is that what is supposed to happen?
    • Internet Explorer 7: OK , with one minor formatting issue: The search button for the Search block is about 1em too high and off the center axis of the search text box.
    • Safari 5.02 (7533.18.5): OK, huge block issue occurs here, otherwise very functional.
  • And...for sanity's sake I'm going to use the abridged format for each pre-test check.
    Book Structure:
    Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

    autocomplete:
    Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

    vertical tabs:
    Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

    teaser splitter
    Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

    menus drag n' drop
    Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

    blocks drag n' drop
    Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

    taxonomy drag n' drop
    Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

    openid login block/page
    Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

    contextual links
    Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

    toolbar
    Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

    color/farbtastic
    Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

    OK, done with the base case. Now I'm going to apply the patch.

cosmicdreams++

but... WAIT! You are testing -dev *with* the patch at #34 applied, right..?

@webchick: I promise that I will eventually test with the patch. But thusfar I've been testing without the patch so that I can report the interactions I'm having with and without the patch. Stay tuned to my expanding comment 51

Oh! I apparently need to add MORE ++s to cosmicdreams++!

Thank you so much, you're an absolute star! :D

after (Testing with same pull of drupal-dev from 7:04 PM Central time)

Overlay:
Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

Dashboard:
Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All behaved the same, which means they all had the same flaw. I was able to reproduce the missing title to the search block issue I saw previously, only it was arguably worse. Instead of the header of the block disappearing, the "Configure Block" list item was showing. And that makes the title of the block change to Configure Block when you put it back into the group of disabled dashboard blocks. Here's how to reproduce

1. Disable all dashboard blocks by dragging them to the header of the dashboard where disabled or unused blocks are supposed to go.
2. Go away from the page or do something else like add a link to the shortcut bar.
3. Add the Search block to the main content area.
4. Drag the Search block back to the disabled area in the header.
5. See Configure block for the title of the search block while in the disabled block or if you drag the search block to one of the dashboard regions.

Now this seems like a minor or normal issue because if you click the done button the proper title will show up. But I'm just reporting for the sake of being thorough.

Book Structure:
Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

autocomplete:
Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

vertical tabs:
Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

teaser splitter
Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

menus drag n' drop
Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

blocks drag n' drop and select option from dropdown
Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

taxonomy drag n' drop
Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

openid login block/page
Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

contextual links
Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

toolbar
Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All OK

color/farbtastic
Tested : Chrome 9 & 7, FF3.6, IE 8 & 7, Safari 5 : All MOSTLY OK

I was able to find a minor issue with the farbtastic/color javascript. If you have a "corner" color like #FFF (in the square) and have the other circle (the one in the ring) move close to the one in the square, you might have difficulty selecting the right circle. If I put the mouse on the quandrant of the circle that is closest to the outer-ring's circle I usually click the outer-ring circle instead of the square's circle.

Does that make sense?

Like I said, VERY minor, shouldn't block this bug, and probably a pre-existing issue.

So in summary, this patch has only one noticeable effect on the correctness of the javascript code (as far as I can tell). It makes a pre-existing issue a tiny bit worse.

I suppose we should do a retest of everything I just did once we have the finalized patch from the jquery team. I hope this test serves as a reference point if anything in the finalized patch seems screwy.

I strongly disagree with #3 that:

There is no reason in the world to ship Drupal 7 with an outdated version of jQuery.

There is an extremely good reason to ship Drupal 7 with an outdated version jQuery. The reason should be blindingly obvious: this and the other couple of "critical" bugs are blocking the progress of Drupal 7 out the door!

By all means rush to get this included before Drupal 7 release, but I think this should be downgraded to "major" priority, since it really is not in the slightest way a bug, nor in the slightest way blocking.

Let's not mix "desperately keen to get some latest feature in" with "critical bug".

As this is such a hot-potato issue, I leave it to someone else to make the change!

StatusFileSize
new150.81 KB
PASSED: [[SimpleTest]]: [MySQL] 27,020 pass(es).
[ View ]

Fresh out the door.. jQuery 1.4.4rc3.

Very thorough testing, thank you. WIth the latest patch I was able to reproduce the Dashboard bug but not the color/farbtastic bug in Chrome 7. Hopefully this patch is a step in the right direction.

I plan on redoing all of these tests, but given how long it took me last time, I think it's best if we wait for the final patch to come out.

In the meantime, I'll see if there is already a bug report on the crazy dashboard behavior. I seem to remember I read a number of related bug reports a long time ago.

#58: 944308_jquery-1.4.4rc3.patch queued for re-testing.

from jquery's website it looks like they are done with 1.4.4 : http://bugs.jquery.com/milestone/1.4.4

also this seems to indicate that all bugs for 1.4.4 have been resolved. http://bugs.jquery.com/query?status=!closed&milestone=1.4.4&report=54&or...

Jquery front page says: Current Release: v1.4.4

StatusFileSize
new150.8 KB
PASSED: [[SimpleTest]]: [MySQL] 27,022 pass(es).
[ View ]

1.4.4 final

Status:Needs review» Reviewed & tested by the community

Please, thanks, love you!

Status:Reviewed & tested by the community» Fixed

Great!

Thanks to cosmicdreams's EPIC round of testing on RC2, I'm comfortable committing this without review, because I think we can catch any regressions during the next beta cycle. Thank you so much again, cosmicdreams. You ROCK!

Committed to HEAD.

Awe, webchick. You just made my day!

Status:Fixed» Closed (fixed)
Issue tags:-beta blocker

Automatically closed -- issue fixed for 2 weeks with no activity.