Add basic tests for the translation creation/editing workflow

Yay, that sounds like a test plan :) Do you know how to write tests?

Better title.

Moving to the Entity Translation queue. Read #902760: Change module name so it can work with Core translation for details.

Patch converted to entity_translation. Test part gave me errors, so I had to skip that one.

Patch seems to solve the problem for numeric fields for me, but now I get this error on an empty taxonomy field:

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'tid' cannot be null: INSERT INTO {taxonomy_index} (nid, tid, sticky, created) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3); Array ( [:db_insert_placeholder_0] => 8 [:db_insert_placeholder_1] => [:db_insert_placeholder_2] => 0 [:db_insert_placeholder_3] => 1300313880 ) in taxonomy_field_update() (regel 1702 van modules\taxonomy\taxonomy.module).

Replacing the patched line with;

Old (as in patch):

  ...
  $handler->setTranslation($translation, $form_state['values']);
  field_attach_form_validate($form['#entity_type'], (object) $form['#entity'], $form, $form_state);
  field_attach_update($form['#entity_type'], $form['#entity']);
  ...

new:

  ...
  $handler->setTranslation($translation, $form_state['values']);
  field_attach_form_validate($form['#entity_type'], (object) $form['#entity'], $form, $form_state);
  entity_form_submit_build_entity($form['#entity_type'], (object) $form['#entity'], $form, $form_state);
  field_attach_update($form['#entity_type'], $form['#entity']);
  ...

or with:

  ...
  $handler->setTranslation($translation, $form_state['values']);
  field_attach_form_validate($form['#entity_type'], (object) $form['#entity'], $form, $form_state);
  field_attach_submit($form['#entity_type'], $form['#entity'], $form, $form_state);
  field_attach_update($form['#entity_type'], $form['#entity']);
  ...

Seems to actually save the translation. Anyway, the removal of empty fields is done by the submit handler, not the validate handler. So perhaps the validate line should not be in here at all.

However, I get too many other errors and notices, page not found errors, etc. to reliably patch this single error. I'm also not too deep into fields yet as to say whether my suggestion is the way to go or not. So I won't make a patch out of this.

Aside: for a normal node save, for the empty field removal, you get a trace like;

...
node_form_submit() (submit handler for the form)
  node_form_submit_build_node()
    entity_form_submit_build_entity()
      field_attach_submit()
        _field_invoke_default($op = 'extract_form_values')
        _field_invoke_default($op = 'submit')
          _field Invoke()
            field_default_submit()
              // Filter out empty values.
              $items = _field_filter_items($field, $items);
              // Reorder items to account for drag-n-drop reordering.
              $items = _field_sort_items($field, $items);

#1098106: Translated fields aren't validated (or processed with presave and submit field_attach_ hooks) has a RTBC patch that should fix this issue. Please move there and confirm.

Sorry, reopening this since we have some yummy tests here :)

Here is a rerolled version, tests don't pass atm: peter would you have a look to this?

Committed the attached patch to HEAD, thanks!

I left out the path tests because they were failing and the pathauto ones because they'll need to go in within the other patch.