I get this PDOException when running update.php to update Skinr 6.x-2.x-dev (2010-Oct-08), latest dev releases of both D7 and Skinr (Oct-18)

I have snapshots of code and db saved so I can easily go back and re-run for testing

Screen dumps of relevant area attached as well as skinr snippet from the sql dump I import before I run update.php, there are no data in the tables

If you need more info let me know.

Comments

vikingew’s picture

Status: Active » Needs review

Well made the effort to read the code a bit and a quite simple fix really ;-)

Index: sites/all/modules/skinr/skinr.install
===================================================================
--- sites/all/modules/skinr/skinr.install       (revision 920)
+++ sites/all/modules/skinr/skinr.install       (working copy)
@@ -289,7 +289,7 @@
       'default' => '',
     ));
     db_update('skinr_rules')
-      ->fields(array('type' => 'page'))
+      ->fields(array('rule_type' => 'page'))
       ->execute();
     db_update('skinr')
       ->fields(array('module' => 'rules'))

I don't attach it as a patch because I maintain my sites in a svn repos using the technique of vendor drops for core and modules, so the patch would probably fail anyway although it's correct.

ezra-g’s picture

StatusFileSize
new601 bytes

I rolled this into a patch against HEAD.

Status: Needs review » Needs work

The last submitted patch, 945086.patch, failed testing.

vikingew’s picture

#2 thanks, is it due to site change/update the test fail or? Must be... I can't see any recent commits.

moonray’s picture

Status: Needs work » Needs review

#2: 945086.patch queued for re-testing.

jacine’s picture

Status: Needs review » Fixed

Thank you! I tested and this is all good.

Committed: http://drupal.org/cvs?commit=438630

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.