This is necessary to complete #854926: Replace admin/project/versioncontrol-repositories/list with Views-driven UI.

All vcs repositories have the following data:

  • Update method
  • Last updated
  • Locking

Each of these is stored in the versioncontrol_repositories table but it is stored in the data column in a serialized array.

This is silly to me because every vcs repository is going to need to provide this data and we will want to be able to use it for views integration, etc. Each of these should now have its own column.

CommentFileSizeAuthor
#11 0001-945130-follow-up-add-the-new-fields-in-the-right-ind.patch1.98 KBmarvil07
#7 945130-create-updated-and-update-method-columns.patch3.6 KBtizzo
#3 945130-versioncontrol_repositories-make-update-method-updated-and-locked-columns.patch3.96 KBtizzo

Comments

marvil07’s picture

marvil07 commented
Priority: Normal » Major

Thanks for creating this.

Marking as major, since it's a key change to views integration as mentioned.

tizzo’s picture

tizzo commented
Assigned: Unassigned » tizzo

Since we seem to agree this is a good idea, I'm working on this now...

tizzo’s picture

tizzo commented
StatusFileSize
new 945130-versioncontrol_repositories-make-update-method-updated-and-locked-columns.patch3.96 KB

We obviously need a corresponding patch for the versioncontrol_git module, but this shouldn't break what that module is already doing (data still works, obviously). I have a patch for vcs_git as well but this all needs a bit more testing.

sdboyer’s picture

sdboyer commented

I'm +1 to this, with the exception of the locking column. That should be done using the semaphore table, and the appropriate APIs. Which will also mean requiring....erm, 6.14, maybe? Whatever core version introduced the semaphore table.

marvil07’s picture

marvil07 commented
Status: Active » Needs work

That totally make sense, I completely forgot about that(aka I've never use it :-p)

So, marking it accordingly.

marvil07’s picture

marvil07 commented
Title: Update versioncontrol_repositories table to have update method, updated, and locked columns. » Update versioncontrol_repositories table to have update method and updated columns.

See #829040: Ensure locking on log fetch using proper semaphore

tizzo’s picture

tizzo commented
Status: Needs work » Needs review
StatusFileSize
new 945130-create-updated-and-update-method-columns.patch3.6 KB

Created patch that removed the locking column because we have agreed to use the semaphore instead.

tizzo’s picture

tizzo commented
Status: Needs review » Closed (fixed)
Issue tags: +git sprint 3

After Sam's review, committed.

tizzo’s picture

tizzo commented
Status: Closed (fixed) » Fixed
marvil07’s picture

marvil07 commented
Assigned: tizzo » marvil07
Status: Fixed » Needs work

I am working on a follow-up patch(move the fields to the right table ;-) adn the new hook_update_N())

marvil07’s picture

marvil07 commented
Status: Needs work » Fixed
StatusFileSize
new 0001-945130-follow-up-add-the-new-fields-in-the-right-ind.patch1.98 KB

avoiding the hook_update_N() since it is really recently committed :-p

committing this patch

Status: Fixed » Closed (fixed)
Issue tags: -git sprint 3

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +git sprint 3

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

  • Commit 7e21c5c on repository-families, drush-vc-sync-unlock by marvil07: 
    #945130 follow-up: add the new fields in the right index.

  • Commit 7e21c5c on repository-families by marvil07: 
    #945130 follow-up: add the new fields in the right index.