I can't set a skin to be available to all regions, it seems i have to specify each particular region in my skin... is that the desired behavior?

CommentFileSizeAuthor
#3 skinr_947738.patch844 bytesmoonray

Comments

jacine’s picture

jacine
she/her
Location New York
commented

No, you should be able to provide skins for regions in both ways:

skinr[skin_name][features][] = region
skinr[skin_name][features][] = region__regionname

When actually applying rules to regions though, you need to pick a specific region. We should probably give the option to apply a skin to all regions. I'm not sure how useful that would actually be, because of the nature of regions, but it would be more consistent.

When this was originally committed, all we saw was "Committed to CVS" so it's possible it wasn't implemented in the first place.

nomonstersinme’s picture

nomonstersinme commented

i think something wasn't implemented because i have to specifically put region__content or region__sidebar_first for my skin to even appear in rule settings

moonray’s picture

moonray commented
Status: Active » Needs review
StatusFileSize
new skinr_947738.patch844 bytes

Here's a patch.

nomonstersinme’s picture

nomonstersinme commented

this works for me!! thanks bala :)

re-tested the patch with drupal head and this patch still works :)

jacine’s picture

jacine
she/her
Location New York
commented
Status: Needs review » Reviewed & tested by the community

This patch introduces 2 new white space issues. I'll fix them, just would appreciate paying attention to this in the future. Thanks :)

+++ modules/skinr.skinr.inc
@@ -85,13 +85,21 @@ function rules_skinr_form_index_handler($op, &$form, $form_state) {
+  ¶

+++ modules/skinr.skinr.inc
@@ -85,13 +85,21 @@ function rules_skinr_form_index_handler($op, &$form, $form_state) {
+  ¶

Powered by Dreditor.

jacine’s picture

jacine
she/her
Location New York
commented
Assigned: Unassigned » jacine
Status: Reviewed & tested by the community » Fixed

Committed: http://drupal.org/cvs?commit=440798

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.