This makes hides the actual exception messages and makes the whole thing pretty much useless, therefore setting this to major :)

For an example, see http://qa.drupal.org/pifr/test/99279

PDOException: %message in _privatemsg_send() (line 1768 of /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/privatemsg/privatemsg.module).

It seems that %message was changed to !message some time ago (That is imho an API change because it changes how that function works. I use it too in privatemsg.module.

Fix is dead simple...

CommentFileSizeAuthor
fix_message_placeholder.patch744 bytesberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Closed (duplicate)

This was fixed in #951486: Invalid placeholders in exception messages during update, with a better patch.

damien tournoud’s picture

damien tournoud commented

@Berdir: _drupal_decode_exception() has a leading underscore. Use at your own risk.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

True :)

I'd argue that it should be public, since it is a useful helper function, but that doesn't matter here ;)