Core has changed the id of text formats to a string on new installations only.

To verify and test this patch:
- Install Drupal 7 from scratch, enable privatemsg without this patch. Try to send a message. Fails with error. Now apply the patch, run update.php, try again.

CommentFileSizeAuthor
#4 update_format_column3.patch12 KBberdir
#1 update_format_column2.patch8.66 KBberdir
update_format_column.patch8.66 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new update_format_column2.patch8.66 KB

New patch with ending newline.

Status: Needs review » Needs work

The last submitted patch, update_format_column2.patch, failed testing.

BenK’s picture

BenK commented

Berdir,

I tested the patch in #1 just as you described. Started with a fresh install and before the patch I got this error when sending:

Failed to send a message to Ben Kaplan. PDOException: %message in _privatemsg_send() (line 1787 of /Users/benkaplan/git/drupal/sites/all/modules/privatemsg-DRUPAL-7--1/privatemsg.module).

After the patch, the error went away and the message was successfully sent. So this works exactly as you intended.

I won't change the status of this issue yet since the test bot failed...

--Ben

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new update_format_column3.patch12 KB

Updated patch, all tests should now pass.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Yay! Commited.

BenK’s picture

BenK commented

Great. Out of curiosity, which core patch made this change necessary? I must have missed it...

--Ben

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

#934050: Change format into string

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.