1. line breaks are missing
  2. entity_type is not listed as required key and if you forget that then it fatals. Opsie!
CommentFileSizeAuthor
#4 948116-2.patch912 bytesamateescu
#1 948116.patch984 bytesamateescu

Comments

amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new 948116.patch984 bytes

Fixed field_update_instance doxygen.

yched’s picture

yched commented

Thanks amateescu.

Details before this can be committed :

+++ modules/field/field.crud.inc
@@ -697,16 +697,19 @@ function field_create_instance($instance) {
+ * @param array $instance

no "array" please

+++ modules/field/field.crud.inc
@@ -697,16 +697,19 @@ function field_create_instance($instance) {
+ *   - entity_type: The type of the entity the field is attached to.
+ *   - field_name: The name of an existing field.
+ *   - bundle: The bundle this field belongs to.

Logical order is : entity_type, bundle, field_name

Powered by Dreditor.

yched’s picture

yched commented
Status: Needs review » Needs work
amateescu’s picture

amateescu commented
Status: Needs work » Needs review
StatusFileSize
new 948116-2.patch912 bytes

Corrected.

yched’s picture

yched commented
Status: Needs review » Reviewed & tested by the community

Looking good. Thanks !

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Just as a note, yched was wrong in #2 to request that the array be removed from the @param.
http://drupal.org/node/1354#functions

But it's not a big deal, and I wouldn't reopen this issue just to put it back in.

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.