Properly port views functionality to 7.x [#948550]

Something funky is going on with views and skinr and i'm not sure if its a skinr or views issue. Basically javascript in views ui is not working at all anymore (which is probably a views problem) but upon going to another page or editing a view with JS disabled I get the following errors only when i try to edit a views style options:

Notice: Undefined property: view::$style_plugin in views_skinr_preprocess_hook_callback() (line 307 of /Users/admin/Sites/drupal7/sites/all/modules/skinr/modules/views.skinr.inc).
Notice: Trying to get property of non-object in views_skinr_preprocess_hook_callback() (line 307 of /Users/admin/Sites/drupal7/sites/all/modules/skinr/modules/views.skinr.inc).
Notice: Undefined property: view::$style_plugin in views_skinr_preprocess_hook_callback() (line 307 of /Users/admin/Sites/drupal7/sites/all/modules/skinr/modules/views.skinr.inc).
Notice: Trying to get property of non-object in views_skinr_preprocess_hook_callback() (line 307 of /Users/admin/Sites/drupal7/sites/all/modules/skinr/modules/views.skinr.inc).
Notice: Undefined index: widgets in views_skinr_submit_handler_display() (line 203 of /Users/admin/Sites/drupal7/sites/all/modules/skinr/modules/views.skinr.inc).

Comment	File	Size	Author
#8	skinr_948550_8.patch	1.05 KB	moonray
#4	skinr_948550.patch	3.53 KB	moonray
#1	skinr-948550.patch	897 bytes	nomonstersinme

Comments

Comment #1

nomonstersinme commented 22 October 2010 at 15:59

Status:

Active

» Needs review

Status	File	Size
new	skinr-948550.patch	897 bytes

So I looked into this and I got rid of the error, I tested different styles and everything in skinr and views appear to still be working.. this needs to be reviewed by someone more knowledgeable..

Comment #2

jacine

she/her

New York

commented 22 October 2010 at 20:40

Title:	possible conflict with views	» Properly port views functionality to 7.x
Issue tags:		+Needs tests

I'm changing the title here, because I'm not sure that porting this properly was ever attempted.

It's pretty cool that this one simple change was all that it took to mate it work though. :)

Also, this is going to need tests like everything else, so we don't have to kill ourselves testing.

Comment #3

jacine

she/her

New York

commented 8 November 2010 at 21:48

Category:	bug	» task
Status:	Needs review	» Needs work

Per @dereine in #959774: Fatal error: Call to undefined function views_object_cache_get(), the following should be worked into this patch:

It's easy to update. Instead of calling views_object_cache_get use
  ctools_include('object-cache');
  $view = ctools_object_cache_get('view', $name);

Comment #4

moonray commented 9 November 2010 at 19:31

Status:

Needs work

» Needs review

Status	File	Size
new	skinr_948550.patch	3.53 KB

Here's a patch for views that fixes the ctools caches issue, the original patch, and makes contextual links work for views.

Comment #5

jacine

she/her

New York

commented 10 November 2010 at 20:17

Status:

Needs review

» Fixed

Committed :)

http://drupal.org/cvs?commit=449018

Comment #6

24 November 2010 at 20:20

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #7

aanjaneyam commented 6 December 2010 at 23:24

Status:

Closed (fixed)

» Active

In the the latest DEV version I am still getting fatal error regarding undefined views_object_cache at line 267. When i reviewed the views.skinr.inc I found views_object_cache at line 237, 260 and 267.