Before everything was ok. Any ideas? Seems like a problem with the css? Thanks!

CommentFileSizeAuthor
#2 updown.patch1.66 KBdroplet

Comments

droplet’s picture

Priority: Critical » Normal

seems fine to me.

droplet’s picture

Status: Active » Needs review
StatusFileSize
new1.66 KB

I notice what you say when I get a clean install.

AntiNSA’s picture

The problem is now the text is gone and there are now two down red arrows.... you can see what I mean @ thecenterofthenet.com

AntiNSA’s picture

Priority: Normal » Major
droplet’s picture

missing a end tag at your site.

check the see if any error there:
widgets\upanddown\widget.tpl.php

AntiNSA’s picture

Your right, thanks for the great module!

marvil07’s picture

Status: Needs review » Postponed (maintainer needs more info)
+++ widgets/upanddown/widget.tpl.php	24 Oct 2010 00:14:49 -0000
@@ -11,14 +11,14 @@
+      <a href="<?php print $link_up; ?>" rel="nofollow" class="<?php print "$link_class_up $class_up"; ?>" title="<?php print t('Vote up!'); ?>"><span class="<?php print $class_up; ?>" title="<?php print t('Vote up!'); ?>"></span></a>

The patch is adding an empty span with a title attribute. I suppose the problem is that there is no a tool-tip on the widget, but I really can not see any difference(I can see the tool-tip), since there is already a tool-tip in the anchor that is one level on top of the span introduced, so, can someone please explain me what I am missing?

Powered by Dreditor.

droplet’s picture

Status: Postponed (maintainer needs more info) » Needs work

@marvil07,
you missing the second changes.

<div class="element-invisible"><?php print t('Vote down!'); ?></div>

we haven't hide it in CSS

Im look back to the code and think we missing patch it in #815984: Make widgets readable by screen readers

marvil07’s picture

Priority: Major » Normal
Status: Needs work » Postponed (maintainer needs more info)

I think I am not getting it right the problem, the mentioned issue #815984: Make widgets readable by screen readers adds an invisible css class to help srceen readers, but tooltip is still there.

An explanation, screenshot or video would be great to understand it :-)

BTW is this happening on all widgets or some of them?

droplet’s picture

only this widgets/upanddown/

you can see the old code:

<div class="element-invisible"><?php print t('Vote down!'); ?></div>

which has NOT define any css (.element-invisible) style in stylesheet to hide the texts

http://drupalcode.org/viewvc/drupal/contributions/modules/vote_up_down/w...

"Vote down!" should be invisible text there but now is showing. (not related to tooltips )

droplet’s picture

Status: Postponed (maintainer needs more info) » Closed (duplicate)

new patch submitted to #815984: Make widgets readable by screen readers and it is duplicated i think. reopen again if it is not. thanks.