The filter_cron() is expiring all the cache_filter items in the cache, this is also being don't with all cache tables including the cache_filter in the system module.

see http://api.drupalecommerce.org/api/function/system_cron/7 and http://api.drupalecommerce.org/api/function/filter_cron/7

CommentFileSizeAuthor
#5 951726-D6.patch1.44 KBswentel
#1 951726.patch1015 bytesswentel

Comments

swentel’s picture

swentel commented
Status: Active » Needs review
StatusFileSize
new 951726.patch1015 bytes

True, that one can actually go.

gordon’s picture

gordon commented

This could also be backported to Drupal 6.x as well sometime.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community
dries’s picture

dries commented
Version: 7.x-dev » 6.x-dev
Status: Reviewed & tested by the community » Needs review

Committed to CVS HEAD. Moving to D6.

swentel’s picture

swentel commented
StatusFileSize
new 951726-D6.patch1.44 KB

D6 patch

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

There's reason to cleanup this on cron within system and filter module both.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

I'm a bit hesitant on this actually. Does it mean any measurable performance improvement? (Notice we are changing the API by removing a function that was not really intended to be invoked directly but somebody might have done so).

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 951726.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Reviewed & tested by the community

I think this function could be safely removed because it's just a code cleanup.

I think if someone use a core hook implementation for any reasons - this eay is wrong.

The performance improvement could be visible only on highload systems because of time-frame between two cleanups (system & filter) module). Anyway this is a -1 within "delete query" so hook_cron could run a bit faster

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Looking for more feedback.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Needs review

Maybe we will get some more feedback this way?

gordon’s picture

gordon commented

This is really just to a clean up and to remove a duplicate process, as clearing the filter cache twice is not going to clear out the filter cache anymore than it 1 clear cache process is going to do.

It is not a performance improvement but getting rid of some code rot.

Gordon.

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.