When you run across the "Close the drawer" link in a screen reader, it sounds like "Close the door." I've seen two different screen reader users get confused by it. And even if they knew it said "drawer," it still wouldn't make any sense without the visual context of the shortcut bar. Can we change "Open the drawer"/"Close the drawer" to "Show shortcuts"/"Hide shortcuts"?

CommentFileSizeAuthor
#9 showhide-shortcuts.patch3.16 KByoroy

Comments

Everett Zufelt’s picture

Everett Zufelt commented

+1 This change makes sense to me. I like the Show / Hide shortcuts text.

David_Rothstein’s picture

David_Rothstein commented

Note that the word "drawer" is also used in the toolbar module's help text, it seems...

In theory, by the way, something other than shortcuts can appear inside of it (although not anything provided by Drupal core).

james.elliott’s picture

james.elliott commented

"Close the drawer" is ambiguous. But I don't think that "Show shortcuts" and "Hide shortcuts" is the answer.

The text was changed from "Show shortcuts" to "Show the drawer" in #540282: Accessibility improvements for the toolbar

My suggestion would be "Close the toolbar drawer".

Everett Zufelt’s picture

Everett Zufelt commented

I don't think users know what a "drawer" is. That being said, perhaps it's time to learn. I mean, drawers are UI components that do show up in some desktop applications as well. I do think that Hide / Show is better terminology than close / open, since it actually reflects a concept that users are familiar with.

bowersox’s picture

bowersox commented

"Hide toolbar shortcuts / Show toolbar shortcuts" -- this one looks best to me

"Hide the toolbar drawer / Show the toolbar drawer" -- this might still sound like "hide the toolbar door" in a screenreader

The toolbar links will usually be shortcuts. I suspect that "shortcuts" makes more sense to users than "drawer" or "door".

james.elliott’s picture

james.elliott commented

The problem with using shortcuts is that any module can inject items into the toolbar drawer, not just the shortcut module. Showing the toolbar shortcuts when there aren't any shortcuts would be more awkward than the "Show the toolbar drawer".

mgifford’s picture

mgifford
he/him
Primary language English
commented

So is there a way to improve this? Is there a generalized way to express this to accommodate the many ways this tool can be used?

Bojhan’s picture

Bojhan commented

Patch please, what we use in help text shouldn't matter. If contribs change the use of this, they should adjust this label accordingly.

yoroy’s picture

yoroy commented
Status: Active » Needs review
StatusFileSize
new showhide-shortcuts.patch3.16 KB

I went with 'Show shortcuts', 'Hide shortcuts'

EvanDonovan’s picture

EvanDonovan commented
Status: Needs review » Reviewed & tested by the community

Reviewed & tested this simple change. I agree with Bojhan on this - RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

My only concern with that approach is we are coding in a reference to "Shortcut" in Toolbar module, and the two are separate. However, I agree the string as-is is very confusing.

I asked David Rothstein about this and his response was:

webchick: I think the world is unlikely to end as a result of doing that :)

Ergo, committed to HEAD.

Status: Fixed » Closed (fixed)
Issue tags: -String freeze, -Accessibility

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +String freeze, +Accessibility

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.