Steps to repeat:

  1. Add Image Style
  2. Create Image Style Name
  3. Edit Image Style Name
  4. Add new image effect

Perhaps easiest to just not allow editing of the image style name after initial creation?

CommentFileSizeAuthor
#7 67816-7.patch811 bytesjody lynn
#3 image-style-form-D7.patch1.62 KBJStarcher
#2 image-style-form-D7.patch1.62 KBJStarcher
#1 edit-image-style.patch1.62 KBJStarcher

Comments

JStarcher’s picture

JStarcher commented
StatusFileSize
new edit-image-style.patch1.62 KB

Here is the best solution I've come up with yet. It is much better than without the patch, though I feel this could be done in an even cleaner way hopefully without javascript. Any other ideas?

JStarcher’s picture

JStarcher commented
StatusFileSize
new image-style-form-D7.patch1.62 KB

Same patch just renamed. Uggh still did not go to unit testing :(

JStarcher’s picture

JStarcher commented
Component: image system » image.module
StatusFileSize
new image-style-form-D7.patch1.62 KB
aaron’s picture

aaron commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, edit-image-style.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) commented
Version: 7.x-dev » 8.x-dev

This is still an issue in D8 when adding effects with configuration screens like Crop.

jody lynn’s picture

jody lynn
she/her
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 67816-7.patch811 bytes

This doesn't need a js workaround, just a correct redirect to go to the URL for the updated image style name when you click 'Add'.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Priority: Minor » Normal
Issue tags: +Needs backport to D7

I'm not sure that this needs tests, this seems like an oversight with a straightforward fix.

Status: Needs review » Needs work
Issue tags: -Needs backport to D7

The last submitted patch, 67816-7.patch, failed testing.

jody lynn’s picture

jody lynn
she/her
Primary language English
commented
Status: Needs work » Needs review
Issue tags: +Needs backport to D7

#7: 67816-7.patch queued for re-testing.

swentel’s picture

swentel commented

Been trying to reproduce, but this seems to be working fine now in D8, not sure about D7 though.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Version: 8.x-dev » 7.x-dev
Status: Needs review » Needs work

I cannot reproduce in 8. Switching back to D7.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs work » Active

I cannot reproduce in D7

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Active » Closed (works as designed)

I tried too D7. Cannot reproduce. Closing.