Hello,
I'm curious if this is an error that I can ignore. I upgraded from 6.x-1.3 to 6.x-2.x-dev and got this error (all other messages were fine)
"Can't DROP 'uid'; check that column/key exists query: ALTER TABLE pm_index DROP INDEX uid in /home/****/public_html/includes/database.mysql-common.inc on line 448"
Thank you for your help

CommentFileSizeAuthor
#7 fix_upgrade_path_and_add_better_indexes_for_2x_too.patch6.89 KBberdir
#3 fix_upgrade_path_and_add_better_indexes.patch4.56 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Yes, you can ignore this.

We renamed that in 6.x-1.3, that's why it doesn't work anymore.

It will produce a problem for PostgreSQL users, however, I'll look into it.

Ela’s picture

Ela commented

Thank you :)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new fix_upgrade_path_and_add_better_indexes.patch4.56 KB

The following patch should fix all reported errors in the 6.x-1.x to 6.x-2.x upgrade path.

Note that only this means that only upgrading from 6.x-1.3 or later is supported now.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
Ela’s picture

Ela commented

Should I still apply this patch even though I have 2.x running already?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

No, this won't help you, at least not the current patch.

The only thing you could do is try to repeat your upgrade with an old backup for testing purposes only, to verify that the errors are really gone now.

I will try to add a update function to improve the current 6.x-2.x installations too but this is unfortunatly not trivial because the APIs given by Drupal 6 are very limiting.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new fix_upgrade_path_and_add_better_indexes_for_2x_too.patch6.89 KB

Ok, here is a new patch.

This contains a backport of the db_index_exists() function in D7 and some new update functions which will try to clean up the index mess in 6.x-2.x.

Please try the patch with whatever versions you have, this should now properly update from 6.x-1.3+ and 6.x-2.x with the same end result.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Commited.

Ela’s picture

Ela commented

sorry... did not get a chance to report. As you probably know all went through without any errors :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.