In Panels Everywhere, I'm working on a system that doesn't use the normal layout, since I replace page.tpl.php with a Panels layout.

I do, however, want (where possible) to retain things like block styling.

In Bartik, block styling depends upon what type of region it's in; i.e, the sidebar, triptych or whatever. However, the actual class used for this also controls layout. i.e,

.block .sidebar {
  // block styling information here
}

The problem is that when not using Bartik's basic layout, I cannot access this style. The sidebar class comes with a width which then tries to apply to whatever region I put that in.

I'm not sure exactly the best way to deal with this, but it would be great (for me) if either the .sidebar class did not include the width or if some other class was used on sidebars to indicate styling. I like sidebar a lot because it's a generic class that's easy to apply, so it would be nicest if the layout information were applied to the more specific type of sidebar.

Comments

tim.plunkett’s picture

Assigned: Unassigned » tim.plunkett

This might be easier than I first thought. Stay tuned.

tim.plunkett’s picture

Status: Active » Needs review
StatusFileSize
new649 bytes

I have to test this, but I figured I'd post it anyway. I think this is a very reasonable change.

tim.plunkett’s picture

Assigned: tim.plunkett » Unassigned

Hm, I can't think of any screenshots I could take that would prove that this works. Either way, it doesn't make a difference to Bartik, but if it makes Panels Everywhere work easier, then I don't see why this shouldn't go in.

merlinofchaos’s picture

Status: Needs review » Reviewed & tested by the community

I can't imagine this CSS change causing any problems at all. It works in basic usage just fine.

Jeff Burnz’s picture

Cant see any issues with this, looks fine, +1.

Just for clarification, I think in the OP the selector being referred to is actually .sidebar .block rather than .block .sidebar

dries’s picture

Status: Reviewed & tested by the community » Fixed

Alright. Committed to CVS HEAD.

Jeff Burnz’s picture

Priority: Normal » Major
Status: Fixed » Needs review
Issue tags: +Quick fix
StatusFileSize
new987 bytes

Earlier patch missed RTL so atm the ID's are overriding the class based selector in RTL (which as you might assume borks the layout in RTL. Ops...

Easy fix...

Jeff Burnz’s picture

StatusFileSize
new560 bytes

Sorry, patch in #7 has some rubbish in it...

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

D'oh.

dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.