In Panels Everywhere, I'm working on a system that doesn't use the normal layout, since I replace page.tpl.php with a Panels layout.
I do, however, want (where possible) to retain things like block styling.
In Bartik, block styling depends upon what type of region it's in; i.e, the sidebar, triptych or whatever. However, the actual class used for this also controls layout. i.e,
.block .sidebar {
// block styling information here
}
The problem is that when not using Bartik's basic layout, I cannot access this style. The sidebar class comes with a width which then tries to apply to whatever region I put that in.
I'm not sure exactly the best way to deal with this, but it would be great (for me) if either the .sidebar class did not include the width or if some other class was used on sidebars to indicate styling. I like sidebar a lot because it's a generic class that's easy to apply, so it would be nicest if the layout information were applied to the more specific type of sidebar.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | bartik-sidebar-layout-rtl.patch | 560 bytes | Jeff Burnz |
| #7 | bartik-sidebar-layout-rtl.patch | 987 bytes | Jeff Burnz |
| #2 | drupal-bartik-973588-2.patch | 649 bytes | tim.plunkett |
Comments
Comment #1
tim.plunkettThis might be easier than I first thought. Stay tuned.
Comment #2
tim.plunkettI have to test this, but I figured I'd post it anyway. I think this is a very reasonable change.
Comment #3
tim.plunkettHm, I can't think of any screenshots I could take that would prove that this works. Either way, it doesn't make a difference to Bartik, but if it makes Panels Everywhere work easier, then I don't see why this shouldn't go in.
Comment #4
merlinofchaos commentedI can't imagine this CSS change causing any problems at all. It works in basic usage just fine.
Comment #5
Jeff Burnz commentedCant see any issues with this, looks fine, +1.
Just for clarification, I think in the OP the selector being referred to is actually
.sidebar .blockrather than.block .sidebarComment #6
dries commentedAlright. Committed to CVS HEAD.
Comment #7
Jeff Burnz commentedEarlier patch missed RTL so atm the ID's are overriding the class based selector in RTL (which as you might assume borks the layout in RTL. Ops...
Easy fix...
Comment #8
Jeff Burnz commentedSorry, patch in #7 has some rubbish in it...
Comment #9
tim.plunkettD'oh.
Comment #10
dries commentedCommitted to CVS HEAD. Thanks.