Hello,

attaching a patch that fixes a PHP 5.3 warning about a value passed as reference to securepages_prevent_hijack_form_alter().

Thanks,
Antonio

CommentFileSizeAuthor
securepages_prevent_hijack-php5.3--0.patch502 bytesakanouras

Comments

Status: Needs review » Needs work

The last submitted patch, securepages_prevent_hijack-php5.3--0.patch, failed testing.

akanouras’s picture

akanouras commented
Status: Needs work » Active
Issue tags: +php5.3

Umm, are these tests failing anyway for this module?

There are calls to undefined functions and all kinds of other weirdness in there.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs work

hook_form_alter's second argument is supposed to be passed by reference, so why is the patch needed?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

- Dependencies need to be defined with 'dependencies' => array('some_module') in getInfo().

- Patch is not needed, instead, you need to figure out which module is calling hook_form_alter the wrong way. These are usually modules with ajax/ahah form elements which then use drupal_alter('form', $form, $form_state).

grendzy’s picture

grendzy commented
Status: Needs work » Closed (works as designed)

closing, per #3.