While trying to use string overrides to change "blue smurf" or "bike shed" #242048: Replace "blue smurf" in no search results message in search_help() when no results are returned, it seems awkward to have to override the entire <ul> element and contrary to a) the documentation of the t() function and b) the other cases within the switch routine in the same function.
Both case 'admin/help#search': and case 'admin/config/search/settings': use multiple t() calls. However, case 'search#noresults': passes the entire result through t().
Changing case 'search#noresults': to more closely mimic the other cases seems to be more consistent and more easily translatable.
Patch forthcoming.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | d7_974740.patch | 1.49 KB | eporama |
Comments
Comment #1
eporama commentedPatch for Drupal-7 head.
Comment #2
eporama commentedshould have changed the status when adding the patch.
Comment #3
jhodgdonThe reason this was done that way is so that the entire help text could be overridden in one text override.
Comment #4
jhodgdonWith this change, you are locked into the structure of UL/LI, which may not be desirable for all sites, plus you are locked into having 3 bullet points, making it impossible to add more. I think we should leave it as it is.