Closed (outdated)
Project:
Drupal core
Version:
7.x-dev
Component:
Garland theme
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Nov 2010 at 07:41 UTC
Updated:
22 Mar 2013 at 17:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
johnalbinAnd here's a patch that puts the permalink directly next to the comment title.
Comment #2
johnalbinHere's before and after shots.
Before:

After:

Comment #4
johnalbin#1: 975254-garland-permalink.patch queued for re-testing.
Comment #5
markabur commented#1: 975254-garland-permalink.patch queued for re-testing.
Comment #7
markabur commentedReroll attached. Patch looks pretty good. This rule:
causes the "Permalink" text to line up with the H3's baseline in Safari/Mac as in the screenshot above, but makes it a couple pixels low in FF/Mac. Removing the rule makes it line up properly in FF but makes it too high in Safari. I messed with a bit and couldn't find anything that worked better. I haven't looked at it in IE yet.
Comment #8
catchPatch looks fine but this is not a major bug. Not sure whether it is sufficiently bad to break markup freeze but tagging for backport so it doesn't get lost at leat.
Comment #9
kscheirer#7: 975254-garland-permalink-2.patch queued for re-testing.
Comment #11
amateescu commentedThe Garland theme has been removed from D8: #911054: Remove Garland from Core
Comment #12
mahaprasad commentedApplied patch #7 & its failed.
for more info please find below details:
quickstart@qs10:~/websites/drupal7.dev$ patch -p1 < ../Patch/975254-garland-permalink-2.patch
patching file garland/comment.tpl.php
Hunk #1 FAILED at 5.
1 out of 1 hunk FAILED -- saving rejects to file garland/comment.tpl.php.rej
patching file garland/style-rtl.css
Hunk #1 FAILED at 233.
1 out of 1 hunk FAILED -- saving rejects to file garland/style-rtl.css.rej
patching file garland/style.css
Hunk #1 FAILED at 857.
1 out of 1 hunk FAILED -- saving rejects to file garland/style.css.rej
patching file garland/template.php
Hunk #1 FAILED at 131.
1 out of 1 hunk FAILED -- saving rejects to file garland/template.php.rej
I will re-rolled the patch #7 & upload the same.
Thank You!
Comment #13
mahaprasad commentedI have re-rolled #7 patch. Please review.
Comment #14
mahaprasad commentedComment #15
mahaprasad commentedPlease find the tested screen shots.
Before Patch:

After Patch:

Comment #16
mattih commentedTest passed.