Same as before. theme_username calls format_username which expects a fully-loaded not-half-ass user object.

CommentFileSizeAuthor
#9 976114_user_format_name-to-require-user-object_9.patch605 bytesandrewbelcher
#8 976114_pass-user_format_name-correct-object_8.patch2.62 KBandrewbelcher
#1 976114-theme-username-user-object-D7.patch16.47 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 976114-theme-username-user-object-D7.patch16.47 KB

Status: Needs review » Needs work

The last submitted patch, 976114-theme-username-user-object-D7.patch, failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Issue tags: +realname, +format_username
Anonymous’s picture

Anonymous (not verified) commented

I'm wondering if this is still an issue. Where were the calls to theme_username that used a half-ass user object?

barraponto’s picture

barraponto
he / him
commented

@linclark probably from theme land :)

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 7.x-dev » 8.x-dev

This still happens in core with format_username(). This still needs to solve the fact that comments can be anonymous, so we'd need to override the loaded $account object with properties from the comment entity before passing it into format_username().

xjm’s picture

xjm
she/her
Primary language English
commented

Marked #1554596: Preprocess Node passes wrong object to format_username and #1554576: Preprocess functions passing wrong objects to format_username() as duplicates of this issue.

andrewbelcher’s picture

andrewbelcher commented
StatusFileSize
new 976114_pass-user_format_name-correct-object_8.patch2.62 KB

I've rerolled against D8 and merged the patches from the two issues xjm has marked as duplicates of this... I'm expecting it to fail on anonymous comment names, as I'm not 100% sure which properties it needs, but hopefully it'll save someone else some time.

andrewbelcher’s picture

andrewbelcher commented
Status: Needs work » Needs review
StatusFileSize
new 976114_user_format_name-to-require-user-object_9.patch605 bytes

Here is another patch that we might want - requiring the argument to user_format_name() to be a User object. Currently it breaks everything due to the session user being a stdClass, so I doubt we want to apply it before that's fixed, but might be good to do once it is fixed.

Setting to needs review so that patches get tested, but I'm expecting them both to fail...

Status: Needs review » Needs work
Issue tags: -realname, -format_username

The last submitted patch, 976114_user_format_name-to-require-user-object_9.patch, failed testing.

Issue tags: +realname, +format_username

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Assigned: dave reid » Unassigned
Issue summary: View changes
andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 8.0.x-dev » 7.x-dev

8.x already fixed and format_username() accepts AccountInterface

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#1929420: $account->getDisplayName() should be used when outputing username in RDF module

the remaining issue in 8.x

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.