Closed (fixed)
Project:
Entity API
Version:
7.x-1.x-dev
Component:
Entity CRUD API - main
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Nov 2010 at 01:17 UTC
Updated:
15 Dec 2010 at 19:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
fagoI agree that it was a bad idea to add into the entity API project at all, as I would not suggest anyone to use it as the entity base class.
It's pretty much there as I use it for Rules, as it uses it to implement its action detection mechanism, which I'd really love to scratch in favour of just having a single class per action - which would benefit from the autoloading mechanism. --> D8, for D7 I felt like this would break too much with the way the people are used to write actions. I should have changed that anyway.
However, I see no cause to not scratch it here + let it Rules implement on its own.
Comment #2
klausiYep, Faces is powerful, but only necessary for very advanced purposes. On the downside it adds a lot of complexity, so let's remove it from Entity to keep it as simple as possible. Patch attached.
Comment #3
fagothanks. I think we'll also need to add in classes to retain BC for modules having used the faces variants (but actually never used faces).
I've just added faces.inc to Rules, to make sure its in place there when it's gone from the entity API.
Comment #4
sunEven though there seems to be a beta release already, this module actually is still pre-alpha right now, so screw BC.
Comment #5
fagoI'm fine with that change, as I assume no-one except me actually really uses the faces API in a custom module. Still I think there are some modules that just use the faces class without actually using faces (I think search_api does) - for them we need to provide the class EntityDBExtendable just extending Entity, for BC.
Comment #6
klausiOk, keeping 3 lines of code with that old classes.
Comment #7
klausiGrammar mistake: "These" instead of "This"
Comment #8
fagothanks, committed.
Comment #9
klausiI don't see the commit, did you push it?
Comment #10
fagogrml, CVS
$Id$let the Git cvs export script fail. I worked around that and finally committed it.