Forms for custom pages only ever show the default; ditto the pages they should alter.

Patch coming.

CommentFileSizeAuthor
#1 981900.nodewords.custom-pages-tags-not-loaded.patch507 bytesjoachim

Comments

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 981900.nodewords.custom-pages-tags-not-loaded.patch507 bytes

Here's a patch.

The tags were getting saved, but not loaded.

mavimo’s picture

mavimo commented
Status: Needs review » Reviewed & tested by the community

#981900: custom pages tags don't get loaded & #981902: custom pages tags don't get shown on pages solve problem with custom pages.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Fixed

This has already been fixed in the latest code, 6.x-1.x-dev. No commit needed. Please be sure to roll patches against 6.x-1.x-dev.

joachim’s picture

joachim commented

But 6.x-1.x-dev doesn't work, and appears to be a pretty big move away from the codebase in the most recent stable release.

What is going on with this module? Just how many lines of development are there on 6?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

It works just fine. Please post bug reports rather than "doesn't work".

joachim’s picture

joachim commented

Excuse me. I posted patches.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

But 6.x-1.x-dev doesn't work

Your patch here is for 6.x-1.11, not 6.x-1.x-dev, which is what you and I both were referring to.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

@joachim: yes, this module went through a huge refactoring (is "refactoring" the right word when it went through feature bloat and became even more of a UX mess?) as part of the v6.x-1.12 development cycle, all of which was done before Dave and I took over the module. All we've been doing so far is trying to fix bugs, get it ready to have the first actually stable release in two years, and plan on how to make some simple yet important improvements in v6.x-1.13 and v6.x-1.14. So yes, we do know that right now the module is a bit of a turkey :)

joachim’s picture

joachim commented

Thanks for the explanation Damien :)

It did indeed look like the 6.x-1.x was more of a new branch than a continuation from 6.x-1.12!

Unfortunately these fixes were for a project on a very tight deadline, so I had to get something working and fast. Will try to help out when I next have a site using this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.