The $options parameter only make sense if it is applied to the object in which it was created. IMHO it does not make sense to actually pass it to the objects that are created/updated.

Not really sure if have described the problem enough, but I suppose the patch is better to read ;-)

CommentFileSizeAuthor
#1 0001-bug-983202-Stop-passing-the-same-options-parameter-i.patch3.93 KBmarvil07

Comments

marvil07’s picture

marvil07 commented
Status: Active » Needs review
StatusFileSize
new 0001-bug-983202-Stop-passing-the-same-options-parameter-i.patch3.93 KB

Here the patch.

@sdboyer: It would be great if you can RTBC this before I commit this :-)

sdboyer’s picture

sdboyer commented
Status: Needs review » Reviewed & tested by the community

Yeah, I was undecided on whether $options should proceed down nesting layers and initially opted to pass it (with the idea that there could be options set eventually, or by some unwitting backend, that would need to be recursive), but with the way it's working right now, we don't need to pass it down. It's probably more trouble than it's worth right now.

marvil07’s picture

marvil07 commented
Status: Reviewed & tested by the community » Fixed

Great :-), committed.

Status: Fixed » Closed (fixed)
Issue tags: -git phase 2, -git sprint 5

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +git phase 2, +git sprint 5

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

  • Commit 6667d13 on repository-families, drush-vc-sync-unlock by marvil07: 
    bug #983202: Stop passing the same $options parameter in cascade on...

  • Commit 6667d13 on repository-families by marvil07: 
    bug #983202: Stop passing the same $options parameter in cascade on...