I've been putting in backports to the 6.x-2.x branch of SimpleTest and there's a couple things that can/should be cleaned up in the Mollom test case:
1. drupalPost() function signature has changed and will cause strict errors with PHP 5.3 since they don't match
2. setUp() can now just get a single argument of an array of modules to install. We can dump call_user_func_array() and just use parent::setUp().

CommentFileSizeAuthor
#4 985880-mollom-test-cleanup.patch2.13 KBdave reid
#1 985880-mollom-test-cleanup.patch1.81 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 985880-mollom-test-cleanup.patch1.81 KB

Status: Needs review » Needs work

The last submitted patch, 985880-mollom-test-cleanup.patch, failed testing.

dries’s picture

dries commented

Thanks for the follow-up, Dave. Any reason why the tests fail?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review
StatusFileSize
new 985880-mollom-test-cleanup.patch2.13 KB

Ah, because that test case has $profile = 'testing' which is now respected with d6 simpletest, but obviously the testing profile doesn't exist in D6.

Status: Needs review » Needs work

The last submitted patch, 985880-mollom-test-cleanup.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Fixed

Those test failures are unrelated.

Thanks for reporting, reviewing, and testing! Committed to D6 (with additional small tweaks).

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.