Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
Bartik theme
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Dec 2010 at 11:51 UTC
Updated:
21 Dec 2010 at 04:50 UTC
Some ID's in preview.html are the same as in page.tpl.php - namely for main-menu and the footer-wrapper etc, this can (not always, can't pinpoint the exact conditions) really screw up the preview... its also invalid markup, not so good eh?
Easy fix, change the ID's in preview.html. This looks like a big patch but really its not, its more of a cleanup which should have really been done in the earlier preview patch, but was overlooked. So in effect this patch does two things:
1. Fix the duplicated invalid ID's
2. Cleanup preview.css (most selectors where way over specified).
I think this is pretty major, it can really mess up the preview and is not tolerable for our default theme.
| Comment | File | Size | Author |
|---|---|---|---|
| bartik-invalid-preview-after.png | 19.24 KB | Jeff Burnz | |
| bartik-invalid-preview-before.png | 18.31 KB | Jeff Burnz | |
| bartik-invalid-preview-markup.patch | 7.5 KB | Jeff Burnz |
Comments
Comment #1
tim.plunkettCode looks great. Now for some testing. I'll have to first find a way to get them to collide, I guess.
Comment #2
tim.plunkettTurn off the overlay, use Bartik as the admin theme. Kabloooey. Use this patch. Success!
Comment #3
jensimmons commented+1
Comment #4
webchickCommitted to HEAD. Thanks.