Closed (fixed)
Project:
Rules
Version:
7.x-2.x-dev
Component:
Scheduler
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
6 Dec 2010 at 16:26 UTC
Updated:
4 Jan 2011 at 13:50 UTC
Jump to comment: Most recent file
This is an attempt to port the Rules Scheduler UI to Drupal 7. I will again use Views to list the scheduled tasks.
With this patch there will be a "Schedule" tab at the Rules configuration pages, pretty similar to admin/rules/rule_sets/scheduling in D6. Furthermore the operation links "execute" and "schedule" are planned for Rules components on admin/config/workflow/rules/components. Work in progress.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 990514-scheduler.patch | 27.78 KB | klausi |
| #2 | 990514-rules-scheduler-ui2.patch | 26.87 KB | klausi |
| #1 | 990514-rules-scheduler-ui.patch | 25.7 KB | klausi |
| rules-scheduler-ui.patch | 10.86 KB | klausi |
Comments
Comment #1
klausiNew patch that includes:
* default View for the scheduled tasks table
* "execute" and "schedule" operation links for components + forms to configure necessary component parameters
* Filter for the scheduled tasks table to only list tasks of a selected component
* Some minor bug fixes for rules_scheduler
@todo: components in the task table should be linked to their edit page
Comment #2
klausiNew patch with linked components in the scheduled tasks view.
Comment #3
fagoThis should be $action I think. It's the same for rules_scheduler_schedule_form_submit().
Missing trailing point.
Let's let a DB-TNG helper do the fetching for us. However it seems wrong to me that we have to do it all. Perhaps you could manage it do work directly with the views form?
I found the following code in views generating the form:
I think the 'delete' context is already clear with the first key's name, so let's just 'config' for the second one.
It seems wrong to me that we have to manually load this include file. If it doesn't work without that, this is a bug.
Also you write "cancellation" and then "canceled", I think both is valid, but we should stay with one variant only.
You may re-use rules_form_submit_rebuild() instead of rules_scheduler_filter_submit().
We can save that $form init, it's not necessary.
The tid is no label, let's use %tid just as 5 lines above.
Shouldn't that be 3.0, or the alpha?
Comment #4
klausiFixed all of the above, except the module_load_include() which is still necessary. We need a function from rules_scheduler.rules.inc in a form submit callback, where Rules integration files are not loaded, right?
Comment #6
fagothanks.
I've took your work and did some more improvements + committed it.
* Fixed condition components to be properly executed.
* Overhauled the rules scheduler to use consistent texts in the rule scheduler UI, such that it always uses "task deletion" and never "cancel".
* Added some small UI improvements.