After saving a nodequeue, I get:

Notice: Undefined property: stdClass::$new in nodequeue_edit_queue_form_submit()

Files: 
CommentFileSizeAuthor
#12 nodequeue-fix_undefined_property_new-997104-12.patch471 byteskolier
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
#11 nodequeue-Fix_undefined_new_property-997104-11.patch412 byteskolier
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
#10 nodequeue-Fix_undefined_new_property-997104-10.patch412 byteskolier
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
#7 nodequeue_undefined_property_997104_7.patch428 byteskurtzhong
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
#1 nodequeue_notice_997104.patch380 bytesbblake
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

Comments

StatusFileSize
new380 bytes
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

Patch included

Status:Active» Needs review

Works fine for me.

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Fixed

Committed.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

StatusFileSize
new428 bytes
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

Sorry for opening this old issue, but it's the almost the same issue:

  • Notice: Undefined property: stdClass::$new in nodequeue_edit_queue_form() (line 504 of nodequeue/includes/nodequeue.admin.inc).
  • Notice: Undefined property: stdClass::$new in nodequeue_edit_queue_form() (line 551 of nodequeue/includes/nodequeue.admin.inc).
  • Notice: Undefined property: stdClass::$new in nodequeue_edit_queue_form() (line 555 of nodequeue/includes/nodequeue.admin.inc).

The following is the patch:

Version:7.x-2.x-dev» 7.x-3.x-dev
Status:Closed (fixed)» Active

Oh, i forgot to change the issue status.

yep, I was getting this too (on 7.x-3.x-dev). Patch in #7 fixes it.

StatusFileSize
new412 bytes
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

I think it's better to add the new property in function nodequeue_load_queues().

Status:Active» Needs review
StatusFileSize
new412 bytes
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

Reupload for the test bot to test the patch.

StatusFileSize
new471 bytes
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

A fixed one.

Status:Needs review» Fixed

Committed, thanks !

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.