The Installation simpletest didn't pass on latest HEAD.

Due to #999072: drupal_system_listing() returns items keyed by 'uri' instead of 'name' when using testing profile in core I removed skinr.test using the testing install profile.

This patch also uninstalls Skinr UI first, before Skinr.

With this patch I get:
38 passes, 0 fails, 2 exceptions, and 16 debug messages

The 2 exceptions are from skinr_ui_admin_skins() but because of I'm going to leave those as is.

CommentFileSizeAuthor
#2 999124-skinr-installation-test-2.patch1.43 KBcoltrane
skinr-installation-test-d7.patch1.22 KBcoltrane

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs work 
+++ tests/skinr.test	15 Dec 2010 16:13:00 -0000
@@ -10,7 +10,6 @@
-  protected $profile = 'testing';

Let's only comment this out and wait for #985578: Duplicate key error in file registry when running tests using testing profile to be fixed.

+++ tests/skinr.test	15 Dec 2010 16:13:00 -0000
@@ -60,9 +59,15 @@ class SkinrInstallationTestCase extends 
-      'uninstall[skinr]' => TRUE,
-      'uninstall[skinr_ui]' => TRUE,
+      'uninstall[skinr_ui]' => 'skinr_ui',
...
+      'uninstall[skinr]' => 'skinr',

I don't think that the value needs to be 'skinr_ui' - TRUE should be sufficient.

Powered by Dreditor.

coltrane’s picture

coltrane
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new 999124-skinr-installation-test-2.patch1.43 KB

Thanks sun.

Will #985578: Duplicate key error in file registry when running tests using testing profile fix #999072: drupal_system_listing() returns items keyed by 'uri' instead of 'name' when using testing profile as well? I have no idea why the testing profile causes different keys.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Very nice observation!

jacine’s picture

jacine
she/her
Location New York
commented
Status: Reviewed & tested by the community » Fixed

Thank you :D

Committed: http://drupal.org/cvs?commit=464854

There's a patch for those 2 exceptions here: #995794: Prevent "invalid argument for foreach()" error.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Fixed » Reviewed & tested by the community 
+++ tests/skinr.test	15 Dec 2010 16:40:51 -0000
@@ -10,7 +10,8 @@
-  protected $profile = 'testing';
+  // Don't use the testing profile until http://drupal.org/node/985578 is fixed.
+  //protected $profile = 'testing';

Core has been fixed, so let's revert that now. :)

Powered by Dreditor.

jacine’s picture

jacine
she/her
Location New York
commented
Status: Reviewed & tested by the community » Fixed

Committed: http://drupal.org/cvs?commit=466090

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.