Write tour integration for user edit page

Tour needs tests since we now have #2028535

Hi lea.refice,

How are your travelling with this issue? Is there anything I can help with?

Nick

Tagging for tour issue tracking.

Since lea.reflce has not done anything yet I have allowed myself to create my first drupal core patch which prepares the tour file for further development.

The patch creates the tour.tour.user-edit file for the user core module in the config folder. It also contains some simple tour tips.

1. +++ core/modules/user/config/tour.tour.user-edit.yml
   @@ -0,0 +1,40 @@
   +id: user
   ...
   +label: User
   

   Lets make this something more specific - eg 'User edit'. Same for the label.

2. +++ core/modules/user/config/tour.tour.user-edit.yml
   @@ -0,0 +1,40 @@
   +    body: 'The <em>username</em>, <em>password</em> and <em>E-Mail address</em> are needed for the user to login.'
   

   Email isn't needed for login. But it is required to be unique. Lets say that.

3. +++ core/modules/user/config/tour.tour.user-edit.yml
   @@ -0,0 +1,40 @@
   +    body: 'The status determinates if the user is able to login or not.'
   

   Lets expand on this. To explain why a blocked account is useful. Also can we link to the settings page where they can set the default value for new users.

4. +++ core/modules/user/config/tour.tour.user-edit.yml
   @@ -0,0 +1,40 @@
   +    body: '<a href="/admin/people/roles">Roles</a> are needed to grant and revoke access for the user to different parts of the system.'
   

   You need to use a token here, sites installed in /drupal won't link with /admin/people/roles. You can use [site:url] then append the path. Grant and revoke 'permissions' instead of access perhaps?

5. +++ core/modules/user/config/tour.tour.user-edit.yml
   @@ -0,0 +1,40 @@
   \ No newline at end of file
   

   Needs newline at end of file

+++ core/modules/user/config/tour.tour.user-edit.yml
@@ -0,0 +1,40 @@
+id: user

This should match the id in the filename (user-edit). I think thats why it doesn't show up when I visit user/*/edit.

Thank you for your feedback! I tried to improve the tour with the help of your suggestions.

Fix for the last broken patch.

The attached patch adds a test for the user/*/edit tour to the patch in #9.

Works for me.

The code may work but the content & wording needs a proper review first

I will have a chat with @pameeela about reviewing the wording on this one. She has become the moderator for the tour content.

Note #1918768: Refactor tour module to use routes instead of paths just landed

Here is the latest patch with includes:
- Update of paths to routes.
- Removal of overlay tips and references in test coverage.

Ready for content review.

In this patch I have fixed the test coverage.

I have updated the schema as per previous fail. Also included a fresh interdiff form before the fail.

This one seems like a good thing to do, but postponed on #1921152-109: META: Start providing tour tips for other core modules. for now.

I am working on this issue in Drupalcon Nashville

The file should be added to the config/install folder. Sending back for new patch file

#36 works well.

Is 'determinates' a verb? Maybe it should be 'determines'?

Updated some verbiage and classes to make the tour point to more appropriate areas of the page. Also moved the yml file to the tour module as appearance is not one that can be uninstalled and reinstalled to add the tour configuration.

Added a tour of the user page (/admin/people) inside of user/config/optional

@ sjpeters79 tested tour-user-edit-create-page-2044399-48.patch

2 issues found:
1) In the 2nd tip, it refers to Language when it should refer to User

I was going to make a patch but there is also another behavior I can't seem to fix so I thought I would bring that up here instead. .

2)
It shows me the number of steps as being 7 instead of 5.

See images
https://i.imgur.com/ZquzEjf.png"

https://imgur.com/5iaRQIW"

First time doing this, so forgive me if not correct, happy to fix

Working on both
tour-user-edit-create-page-2044399-42.patch
and
tour-user-edit-create-page-2044399-48.patch

I produced the attached patch.

I separated tour-user-edit-create-page-2044399-42.patch into 2 files, tour.tour.user-create.yml and tour.tour.user-edit.yml for easier customization of each.
I fixed the previously mention issues with tour-user-edit-create-page-2044399-48.patch

Rerolled patch for 9.1.x. Added tests for all the 3 pages.
Also removed tour tip for "Roles" on User add and edit page as this is not present in the UserCreateTest and UserEditTest as well. The "Roles" element is not found either on the minimal or the standard profile while running php unit tests.
All the other tips for all the pages can now be seen on the respective pages.
Please review the patch!

Fixing failed test cases.

Re-rolled #57 for 9.4

D10 version needed
At this time we would need a D10.1.x patch or MR for this issue.

Commit check failures
The last patch doesn't pass commit checks, could you make sure to run ./core/scripts/dev/commit-code-check.sh before uploading a patch to make sure there are no issues with code formatting. see https://www.drupal.org/docs/develop/development-tools/running-core-devel...

Fixed the CCF for #61.

This extension is being deprecated, see #3336033: [Meta] Tasks to deprecate Tour module. It will be removed from core and moved to a contrib project, #3376099: [11.x] [Meta] Tasks to remove Tour.

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.