I built a slideshow with the Jan 1st release and the cycle was working o.k. in FF and IE. Updated to the Jan 7th release and no more cycle. I tried deleting the view, uninstalling the module and rebuilding the view to no avail. I did re-download the js plugins as well.
Oops?

CommentFileSizeAuthor
#14 1018754-skin_errors-3.patch4.95 KBredndahead
#10 1018754-skin_errors-2.patch1.97 KBredndahead
#6 1018754-skin_errors-1.patch1023 bytesredndahead

Comments

redndahead’s picture

redndahead commented
Status: Active » Postponed (maintainer needs more info)

Do you see any javascript errors? Do you have firebug and know how to use it?

MrPhilbert’s picture

MrPhilbert commented

Firebug did not report any errors. It seems that the cycle library is not being called. I.E. did not report any errors either. If there is a parse error IE would pop up an error. Unfortunately, I did the automatic update so I do not have the Jan. 1st version to compare. If you can upload that as a reply, I would be very happy to help debug. I work on a P.C. and the simple-test module is broken for this platform. I'm on my way to the Seattle Drupal 7 release party so I'll take a look at it this weekend.
Philbert

acarpio’s picture

acarpio commented

Same happened to me but only for slideshows displayed in blocks. The ones displayed in pages are still working.

acarpio’s picture

acarpio commented

But now I have created a new slideshow for a page and it is not cycling.

However, the old one I created with the previous release is still working in the page (but not in the block), but with this messages:

* Notice: Undefined index: skin_info en template_preprocess_views_slideshow() (línea 26 de /Library/WebServer/Documents/mitos/sites/all/modules/views_slideshow/theme/views_slideshow.theme.inc).
* Notice: Undefined index: enable en template_preprocess_views_slideshow() (línea 56 de /Library/WebServer/Documents/mitos/sites/all/modules/views_slideshow/theme/views_slideshow.theme.inc).
* Notice: Undefined index: enable en template_preprocess_views_slideshow() (línea 61 de /Library/WebServer/Documents/mitos/sites/all/modules/views_slideshow/theme/views_slideshow.theme.inc).
* Notice: Undefined index: enable en template_preprocess_views_slideshow() (línea 56 de /Library/WebServer/Documents/mitos/sites/all/modules/views_slideshow/theme/views_slideshow.theme.inc).
* Notice: Undefined index: enable en template_preprocess_views_slideshow() (línea 61 de /Library/WebServer/Documents/mitos/sites/all/modules/views_slideshow/theme/views_slideshow.theme.inc).
* Notice: Undefined index: enable en template_preprocess_views_slideshow() (línea 56 de /Library/WebServer/Documents/mitos/sites/all/modules/views_slideshow/theme/views_slideshow.theme.inc).
* Notice: Undefined index: enable en template_preprocess_views_slideshow() (línea 61 de /Library/WebServer/Documents/mitos/sites/all/modules/views_slideshow/theme/views_slideshow.theme.inc).

redndahead’s picture

redndahead commented

Try editing the settings and saving it again. I don't think that skin_info gets built unless you save the settings again.

redndahead’s picture

redndahead commented
StatusFileSize
new 1018754-skin_errors-1.patch1023 bytes

@acarpio can you try this patch

acarpio’s picture

acarpio commented

I did not tried the patch yet but editing and saving fixed the error messages. And I could make a new page and a new block to cycle.

I'll try my best with the patch, but I'm not sure if I'll can do it (because of my knowledge) and also I don't have the errors anymore...

redndahead’s picture

redndahead commented

I can almost guarantee you'll get the errors again if you clone the display

acarpio’s picture

acarpio commented

You are right, errors are there. I tried the patch but I still have some errors, not anymore about the skin:

* Notice: Undefined index: enable en template_preprocess_views_slideshow() (línea 68 de /Library/WebServer/Documents/mitos/sites/all/modules/views_slideshow/theme/views_slideshow.theme.inc).
* Notice: Undefined index: enable en template_preprocess_views_slideshow() (línea 73 de /Library/WebServer/Documents/mitos/sites/all/modules/views_slideshow/theme/views_slideshow.theme.inc).
* Notice: Undefined index: enable en template_preprocess_views_slideshow() (línea 68 de /Library/WebServer/Documents/mitos/sites/all/modules/views_slideshow/theme/views_slideshow.theme.inc).
* Notice: Undefined index: enable en template_preprocess_views_slideshow() (línea 73 de /Library/WebServer/Documents/mitos/sites/all/modules/views_slideshow/theme/views_slideshow.theme.inc).
* Notice: Undefined index: enable en template_preprocess_views_slideshow() (línea 68 de /Library/WebServer/Documents/mitos/sites/all/modules/views_slideshow/theme/views_slideshow.theme.inc).
* Notice: Undefined index: enable en template_preprocess_views_slideshow() (línea 73 de /Library/WebServer/Documents/mitos/sites/all/modules/views_slideshow/theme/views_slideshow.theme.inc).

redndahead’s picture

redndahead commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new 1018754-skin_errors-2.patch1.97 KB

Can you try with this one please. Thanks for helping with this.

acarpio’s picture

acarpio commented

No problem, glad to help, I wish I could do more.

Patched tried and no more errors. Slideshows seems cycling right both in pages and blocks, everything looks fine.

Thanks.

acarpio’s picture

acarpio commented

Going back to the original problem in this issue: I´m seeing that slideshows with no images (only text fields) are not cycling (they were working on the january 1st but not with the 2 last releases). So it is not about the pages of blocks as I first thought, but it is that in the last releases an image field is needed in order to cycle (or I think so).

MrPhilbert’s picture

MrPhilbert commented

acarpio is right. I created a slideshow with images and it worked. Without images it does not cycle.

redndahead’s picture

redndahead commented
StatusFileSize
new 1018754-skin_errors-3.patch4.95 KB

This should hopefully fix the slideshow without image problems.

MrPhilbert’s picture

MrPhilbert commented

Thank you Mr. Redndahead. It worked!
This is also the first time I've applied a patch ( I used Netbeans). I'm learning more and more each day.
Just goes to show you that even a "Greyndahead" can learn something.

Now maybe this will give me the confidence to peruse the api to try and make a skin?
O.K. maybe the question mark is a little Freudian indicator but I'm getting there.
Mr. Philbert

redndahead’s picture

redndahead commented
Status: Needs review » Fixed

committed this patch. thanks for testing it's really appreciated.

acarpio’s picture

acarpio commented

It its working on last Jan. 9th release. Great work. Thanks!

redndahead’s picture

redndahead commented

@MrPhilbert I updated the documentation on creating skins. Feel free to change it with anything that I may be missing.

http://drupal.org/node/909020

mndonx’s picture

mndonx commented

I'm getting a similar error with a views slideshow, which is not showing at all after one of the recent updates:

Notice: Undefined index: in template_preprocess_views_slideshow() (line 14 of /Users/mndonx/Sites/drupal7/sites/all/modules/views_slideshow/theme/views_slideshow.theme.inc).

Is this the same bug, or something different? I'm not using skins.

redndahead’s picture

redndahead commented

@mdonx Try resaving the slideshow. Depending on the last version you used things may have changed. Looking at that line it seems the issues would be more related to old values.

mndonx’s picture

mndonx commented

OK - My issue was that the jquery.cycle.all.min.js must have been overwritten. It was missing when I edited the slideshow. Should be fine now that it is stored separately in the libraries folder. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.