This patch includes patch Patch: Added using Drupal.behaviors instead of $(document).ready() and JS code optimization. and also removed code that creates JS-variable Drupal.settings.hide_submit.image and uses at client side.

CommentFileSizeAuthor
#3 hide_submit_6.x-1.10_JS_optimization_#1030638.patch6.29 KBvladsavitsky
#4 hide_submit_6.x-1.10_JS_optimization_1030638.patch6.29 KBvladsavitsky
#1 hide_submit_6.x-1.10_JS_optimization_#1030638.patch6.29 KBvladsavitsky

Comments

vladsavitsky’s picture

vladsavitsky commented
Issue tags: +JavaScript, +optimization, +behaviors
StatusFileSize
new hide_submit_6.x-1.10_JS_optimization_#1030638.patch6.29 KB

Patch attached.

optalgin’s picture

optalgin commented

Can't see attachment, link is broken.
please post again (don't use # in filename)
Thanks

vladsavitsky’s picture

vladsavitsky commented
StatusFileSize
new hide_submit_6.x-1.10_JS_optimization_#1030638.patch6.29 KB

Yes. Link is broken.
Here is the same patch attached to this comment.
Update: this one broken too.

vladsavitsky’s picture

vladsavitsky commented
StatusFileSize
new hide_submit_6.x-1.10_JS_optimization_1030638.patch6.29 KB

And again without '#' sign...
Works!

optalgin’s picture

optalgin commented

Hi,
Can you please explain why you think image should be removed from settings?

The reason I put it there is to allow preload the image

    if (settings.image) {
       jQuery("<img>").attr("src",settings.image);
    }
vladsavitsky’s picture

vladsavitsky commented

I have tested and throbber image was shown after appling this patch but seems that browser get it from cache.
(I thought that this image is in CSS).
So this is wrong to just remove this line.
And adding CSS-file for just one background image is silly.
Ok. I'll fix this patch.

chuckbar77’s picture

chuckbar77 commented

subscribing

optalgin’s picture

optalgin commented
Status: Needs review » Closed (won't fix)